Fix Quad Transport Map w/ Slicing and Zero Fields #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
changed the title
The linear transport map of the quad, used in envelope tracking mode, did not scale its lengths properly when set to zero field strength and sliced for space charge effects. This fixes it. Author: Kyrre Ness Sjobak <[email protected]>
ax3l
force-pushed
the
fix-quad-transport-map
branch
from
10c1b81 to
e9926a2
Compare
cemitch99
approved these changes
Jul 9, 2025
Member
cemitch99
left a comment
cemitch99
left a comment
There was a problem hiding this comment.
Yes, excellent. As pointed out - this only affects the result in envelope mode when k=0.
Contributor
|
Ah, thanks. Sorry, I got busy with other things for a few days. I started by writing tests here (not 100% finished), as you requested: I was a little surprised by the tests living in the examples folder, and the test folder being something else... There is also this related bug: Should that also go in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linear transport map of the quad, used in envelope tracking mode, did not scale its lengths properly when set to zero field strength and sliced for space charge effects. This fixes it.
Isolated from #1030
Author: @kyrsjo 🙏