Prepare for const #466
Open
Prepare for const #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@oconnor663 do you think this can be merged as is? I'd like to rebase #439 on it later. I'm using domain separation for hashes in various places and using blake3 hash of a fixed string as a key, which would be nice to do with constants rather than hardcoding values for readability. |
Contributor
Author
|
@oconnor663 any concerns here? I'd really like to somehow make progress on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from #439.
arrayrefusage was reduced due to API being non-constand honestly a bit confusing to use. With a few trivial macros it can be removed in many places (I only touched those relevant to #439) and expanded code is much easier to read.Portable implementation was refactored a bit to make functions
const fn-friendly, but not marked asconst fnjust yet.Hopefully these changes are not too controversial.