Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPA plugin: catch 400 return in fail over for locations #212

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

dschristianson
Copy link
Contributor

Closes #209

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Test coverage >= 90%
  • Flake8 Tests
  • Mypy Tests

Caught integration test failure due to data source update.

Test Configuration

  • Python Version: 3.10

PR Self Evaluatio

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests or modified existing tests that prove my fix is effective or that my feature works
  • Existing unit tests pass locally with my changes
    - [ ] Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

Copy link
Contributor

@vchendrix vchendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschristianson can you tell me a little bit more about why raising the exception on anything but 200 HTTP status code is needed instead of writing it to the synthesis_message? What happens now that is problematic? Why raising the exception is better.

Also, the static mypy tests are failing.

@dschristianson
Copy link
Contributor Author

@vchendrix: It's a fail over mechanism on the preferred url. So I'm forcing an exception so that the backup URL is tried.

@dschristianson
Copy link
Contributor Author

The rebase I just did should fix the mypy issue.

@vchendrix
Copy link
Contributor

vchendrix commented Jan 28, 2025

@vchendrix: It's a fail over mechanism on the preferred url. So I'm forcing an exception so that the backup URL is tried.

where is the backup url that is tried? What does this look like for command line users vs thos who deploy on a web server.

@vchendrix vchendrix merged commit 6add9fe into main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch 400 response status in fail over to csv locations query
2 participants