Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPA plugin enhancements #204

Merged
merged 1 commit into from
Sep 26, 2024
Merged

EPA plugin enhancements #204

merged 1 commit into from
Sep 26, 2024

Conversation

dschristianson
Copy link
Contributor

@dschristianson dschristianson commented Sep 25, 2024

Upgrades to EPA plugin:

Closes #191
Closes #192

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Test coverage >= 90%
  • Flake8 Tests
  • Mypy Tests
  • Other -- manual tests

Test Configuration

  • Python Version: 3.10

PR Self Evaluation

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests or modified existing tests that prove my fix is effective or that my feature works
  • Existing unit tests pass locally with my changes
    - [ ] Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

@dschristianson dschristianson force-pushed the issue-191-192 branch 3 times, most recently from d8c8f7d to cbda500 Compare September 25, 2024 23:12
@dschristianson dschristianson marked this pull request as ready for review September 25, 2024 23:19
@dschristianson dschristianson changed the title DRAFT: EPA plugin enhancements EPA plugin enhancements Sep 25, 2024
vchendrix
vchendrix previously approved these changes Sep 26, 2024
Copy link
Contributor

@vchendrix vchendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have some small things about pydocs and documentation. They are minor and don't need a re-review by me if you address them

@dschristianson
Copy link
Contributor Author

Thanks, @vchendrix! Will address all and push it out the door.

Closes #191
Closes #192

- Add fail over support for GeoServer WFS API to WQP Station request
- Add support for beta 3.0 WQP web service API
- Add integration tests
- Update documentation
@dschristianson dschristianson merged commit 1a6e3ce into main Sep 26, 2024
3 checks passed
@dschristianson dschristianson deleted the issue-191-192 branch September 26, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants