Merged
Conversation
Added a mock instead of the real entry point for tests/entry_points/test_load.py Deleted test_dummy.py Added more tests in test_views.py Moved mocks to conftest.py Added positive and negative situations in test_views.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LucasZimm check this out. I worked on top of your branch #30 . Once you check these, we can merge into your branch, and this into the cookiecutter install.
Here is a summary:
test_views.pyto cover login, logout_view, homepage, and clear_state positive/negative paths, with full mocking of OpenBIS and side effects.I pretty much used CODEX to expand the test_views.py, with some tweeks here and there. Now, I did all of this because: