-
Notifications
You must be signed in to change notification settings - Fork 2.7k
msal-node: Added Logging to HttpClient #8101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Robbie-Microsoft
wants to merge
9
commits into
dev
Choose a base branch
from
rginsburg/http_client_logs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+409
−315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds enhanced logging to the msal-node HttpClient to aid debugging of failed network requests and refactors helper functions into class instance methods.
- Introduces a Logger to HttpClient with PII-aware URL and header logging.
- Refactors previous standalone helper functions (network requests, body parsing, request destruction logic) into private instance methods.
- Updates timeout error messages to include duration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/msal-node/test/network/HttpClient.spec.ts | Adjusts expected timeout error message to include duration. |
| lib/msal-node/src/network/HttpClient.ts | Adds logger integration, converts utility functions to private methods, improves timeout/error handling and PII-aware logging. |
| change/@azure-msal-node-edb8d743-61e2-4f42-a970-92e01f619a49.json | Beachball change file documenting the patch update. |
bgavrilMS
previously approved these changes
Oct 20, 2025
bgavrilMS
approved these changes
Oct 24, 2025
tnorling
reviewed
Oct 24, 2025
bgavrilMS
previously approved these changes
Oct 24, 2025
tnorling
reviewed
Oct 24, 2025
bgavrilMS
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help customers better debug their failed network requests.
Turned HttpClient into a proper class. Now it can utilize instance variable re-use.