Fix InjectionToken types to allow new inject(Token) syntax to be used with msal-angular (#7653) #7745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shylasummers
requested review from
jo-arroyo,
peterzenz and
tnorling
as code owners
Contributor
Author
|
Hi @bradkovach, we needed to make a new PR for your change since some pipeline checks will fail automatically on external PRs. This PR preserves the commit history of your previous PR. |
microsoft-github-policy-service
bot
added
the
Needs: Attention 👋
microsoft-github-policy-service
bot
removed
the
Needs: Attention 👋
tnorling
previously approved these changes
Jul 1, 2025
This PR: - Removes unused `CommonModule` - Uses `styleUrl` instead of `styleUrls` - Uses `inject` for DI - Uses `takeUntilDestroyed` instead of `Subject/OnDestroy` approach - Fixes indents There is a typing issue, which is now solved by a generic in the following line: ```ts private msalGuardConfig = inject<MsalGuardConfiguration>(MSAL_GUARD_CONFIG); ``` I found a fix in the next PR: #7484 After its merge, the generic can be removed: ```ts private msalGuardConfig = inject(MSAL_GUARD_CONFIG); ```
tnorling
approved these changes
Jul 1, 2025
konstantin-msft
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to run #7653 by @bradkovach against CI.