Skip to content

Conversation

nitishm
Copy link
Contributor

@nitishm nitishm commented May 14, 2021

Closes #235

Signed-off-by: Nitish Malhotra [email protected]

Signed-off-by: Nitish Malhotra <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #238 (287b3be) into main (683fc3f) will decrease coverage by 0.11%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   31.31%   31.20%   -0.12%     
==========================================
  Files           5        5              
  Lines        1025     1032       +7     
==========================================
+ Hits          321      322       +1     
- Misses        676      682       +6     
  Partials       28       28              
Impacted Files Coverage Δ
pkg/workflow/argo.go 1.76% <0.00%> (-0.03%) ⬇️
controllers/appgroup_reconciler.go 50.64% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683fc3f...287b3be. Read the comment docs.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small asks

@nitishm nitishm requested a review from jonathan-innis May 18, 2021 21:14
@nitishm
Copy link
Contributor Author

nitishm commented May 19, 2021

@jonathan-innis are we good to merge this?

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nitishm nitishm requested a review from jonathan-innis May 19, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide option to order the release of the application parent chart as compared to the subcharts

3 participants