Skip to content

Conversation

nitishm
Copy link
Contributor

@nitishm nitishm commented May 10, 2021

Closes #216

Signed-off-by: Nitish Malhotra [email protected]

@nitishm nitishm requested a review from davutkarabay May 10, 2021 17:48
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #217 (ae0125d) into main (dfe5e00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   18.54%   18.54%           
=======================================
  Files           5        5           
  Lines         960      960           
=======================================
  Hits          178      178           
  Misses        747      747           
  Partials       35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe5e00...ae0125d. Read the comment docs.

Tiltfile Outdated
dockerfile='Dockerfile')

yaml = local('helm template --namespace orkestra orkestra chart/orkestra --no-hooks --include-crds')
yaml = local('helm template --namespace orkestra orkestra chart/orkestra --create-namespace --no-hooks --include-crds')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have too many orkestra after --namespace here?

Signed-off-by: Nitish Malhotra <[email protected]>
@nitishm nitishm changed the title add --create-namespace flag to tiltfile Tilt not creating namespace and failing to start application May 10, 2021
Signed-off-by: Nitish Malhotra <[email protected]>
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orkestra namespace not being created during Tilt up testing

4 participants