-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update axios to 1.7.5 with a security fix #5114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leah-Xia-Microsoft
requested review from
jimchou-dev,
vhuseinova-msft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai,
palatter,
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft and
prabhjot-msft
September 4, 2024 21:30
Chat bundle size is increased❗.
|
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
emlynmac
approved these changes
Sep 5, 2024
jpeng-ms
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There's still another sub-dependency that's using axios <1.7.4. I've submitted a Github issue on their repo:
playwright-community/jest-process-manager#41 and a Github issue on the Storybook/test-runner side: storybookjs/test-runner#510
Why
How Tested
Process & policy checklist
Is this a breaking change?