Adding rate limit functionality for ingress bandwidth and operations per second #2093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to sourav/rateLimit
…to sourav/rateLimit
…to sourav/rateLimit
…to sourav/rateLimit
souravgupta-msft
requested review from
ashruti-msft,
jainakanksha-msft,
syeleti-msft and
vibhansa-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces configurable rate limiting for Azure Storage operations in Blobfuse2, allowing users to control both download bandwidth (bytes per second) and operation throughput (operations per second). The implementation uses the token bucket algorithm from golang.org/x/time/rate to enforce limits while allowing short bursts.
Key Changes:
- Added configuration options
limit-bytes-per-secandlimit-ops-per-secwith CLI flags and YAML support (default: -1 for unlimited) - Implemented rate limiting policy that enforces bandwidth limits on GET requests with Range headers and operation rate limits on all requests
- Integrated rate limiting policy into the Azure Storage client pipeline as a per-retry policy
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| component/azstorage/azstorage.go | Added CLI flags for limit-bytes-per-sec and limit-ops-per-sec configuration options |
| component/azstorage/config.go | Added rate limiting configuration fields and parsing logic; updated logging to include new limits |
| component/azstorage/config_test.go | Added unit tests for rate limit configuration parsing and validation |
| component/azstorage/connection.go | Added limitBytesPerSec and limitOpsPerSec fields to AzStorageConfig struct |
| component/azstorage/policies.go | Implemented rateLimitingPolicy with bandwidth and operations rate limiting using golang.org/x/time/rate |
| component/azstorage/policies_test.go | Added comprehensive tests for rate limiting policy covering bandwidth limits, ops limits, and no-limit scenarios |
| component/azstorage/utils.go | Added parseRangeHeader utility function; integrated rate limiting policy into client options |
| component/azstorage/utils_test.go | Added unit tests for parseRangeHeader function with various Range header formats |
| go.mod | Added golang.org/x/time v0.14.0 dependency |
| go.sum | Updated checksums for golang.org/x/time dependency |
| NOTICE | Added BSD-3-Clause license notice for golang.org/x/time |
vibhansa-msft
approved these changes
Jan 9, 2026
ashruti-msft
approved these changes
Jan 22, 2026
syeleti-msft
approved these changes
Jan 27, 2026
| capMbpsRead := config.AddInt64Flag("cap-mbps-read", -1, "Limit the throughput of downloads from your storage account. Value measured in megabits per second. Default is -1 (no limit)") | ||
| config.BindPFlag(compName+".cap-mbps-read", capMbpsRead) | ||
|
|
||
| capIOps := config.AddInt64Flag("cap-iops", -1, "Limit the total storage operations per second. Default is -1 (no limit)") |
Member
There was a problem hiding this comment.
is cap-iops also related only to read ?
Member
Author
There was a problem hiding this comment.
No, it applies to all REST calls
syeleti-msft
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces configurable rate limiting for Azure Storage operations, allowing users to limit ingress bandwidth (bytes downloaded per second) and operations per second. The changes include new configuration options, implementation of a rate limiting policy using
golang.org/x/time/rate, integration with the storage pipeline, and comprehensive unit tests for the new functionality.Rate Limiting Feature:
limit-bytes-per-secandlimit-ops-per-sectoAzStorageOptionsand CLI flags, allowing users to set bandwidth and operation rate limits. Default is -1 (unlimited). (component/azstorage/config.go,component/azstorage/azstorage.go)component/azstorage/config.go,component/azstorage/connection.go)golang.org/x/time/rate, which enforces the configured limits for both bandwidth (on GET requests with range headers) and operation rate. (component/azstorage/policies.go)component/azstorage/utils.go)Supporting Changes:
Rangeandx-ms-rangeheaders, determining the size of download requests for bandwidth limiting. (component/azstorage/utils.go)golang.org/x/timefor rate limiting. (go.mod)NOTICE)How Has This Been Tested?
component/azstorage/config_test.go)component/azstorage/policies_test.go)component/azstorage/utils_test.go)Checklist