[APIView] Endpoint definition to get language approvers and admins#15523
Open
AlitzelMendez wants to merge 2 commits intoAzure:mainfrom
Open
[APIView] Endpoint definition to get language approvers and admins#15523AlitzelMendez wants to merge 2 commits intoAzure:mainfrom
AlitzelMendez wants to merge 2 commits intoAzure:mainfrom
Conversation
AlitzelMendez
requested review from
helen229,
maririos,
praveenkuttappan and
tjprescott
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds TypeSpec/OpenAPI documentation for new “permissions” endpoints in APIView (language approvers + admin list) and wires the new spec into the TypeSpec entrypoint so it’s emitted with the rest of the external API surface.
Changes:
- Added
permissions.tspdefining/api/permissions/approvers/{language}and/api/permissions/adminsendpoints under Bearer auth. - Added supporting models for the permissions endpoints (approver/admin info).
- Imported the new TypeSpec file from
main.tspso it’s included in the generated OpenAPI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/dotnet/APIView/APIViewWeb/typespec/permissions.tsp | Adds TypeSpec definitions/models for permissions endpoints (approvers/admins) under /api/permissions. |
| src/dotnet/APIView/APIViewWeb/typespec/main.tsp | Imports permissions.tsp so the endpoints are included in the compiled OpenAPI output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoint definition for: #15414