[AVC] Update golang filter#15520
Merged
tjprescott merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Go-language exception filter for APIView Copilot based on April 2026 feedback, adding two new “do not suggest” rules to prevent factually incorrect or pattern-breaking review comments.
Changes:
- Add a new exception rule disallowing suggestions to change error code constant string values to match constant name capitalization (wire-format values must remain service-defined).
- Add a new exception rule disallowing suggestions to rename
WithNoCredentialfunctions toWithoutCredential(keeps established Go SDK naming patterns).
jhendrixMSFT
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter additions based on a review of feedback collected during April 2026.
Rule 3 added: DO NOT suggest changing error code constant string values to match the constant name's capitalization. Error code values are wire-format strings defined by the service and must not be altered.
Rule 4 added: DO NOT suggest renaming functions that use 'WithNoCredential' to 'WithoutCredential'. The 'NoCredential' naming is the established Go SDK pattern.
Evidence: 2 downvoted comments from jhendrixMSFT on the azblob review (1 FactuallyIncorrect, 1 AcceptedSDKPattern).