[AVC] Update python filter#15519
Open
tjprescott wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the APIView Copilot Python review filter to incorporate April 2026 feedback, preventing suggestions that conflict with Azure SDK for Python generated-code typing patterns.
Changes:
- Added a new filter exception (Rule 24) to avoid suggesting
Union[ModelType, Mapping[str, Any]]for generated model parameters, aligning with generated SDK type signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter additions based on a review of feedback collected during April 2026.
Rule 24 added: DO NOT suggest typing model parameters as
Union[ModelType, Mapping[str, Any]]in generated code. Generated models type parameters with the model class only; dict-input flexibility is handled at runtime, not in the type signature.Evidence: 2 downvoted comments (OutdatedGuideline) from annatisch on the Planetary Computer SDK review. The
python-models-input-dictguideline does not apply to generated code type annotations.