[AVC] Update dotnet filter#15518
Open
tjprescott wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET feedback filter rules used by APIView Copilot to avoid generating suggestions that conflict with accepted Azure SDK patterns.
Changes:
- Adds a new Rule 11 exception to prevent suggestions to hide/remove
Equals(object)overrides on extensible enum structs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter additions based on a review of feedback collected during April 2026.
Rule 11 added: DO NOT suggest hiding or removing Equals(object) overrides on extensible enum structs. These overrides are part of the accepted struct equality pattern.
Evidence: 2 downvoted comments (AcceptedSDKPattern) from christothes.
Note: The remaining 53 feedback items were already covered by existing rules 7 (implicit operators) and 10 (serialization consolidation). Those comments predate the current filter rules.