Fix typespec project repo path for CustomizedCodeUpdateTool#15497
Open
samvaity wants to merge 6 commits into
Open
Fix typespec project repo path for CustomizedCodeUpdateTool#15497samvaity wants to merge 6 commits into
samvaity wants to merge 6 commits into
Conversation
github-actions
Bot
added
the
azsdk-cli
ronniegeraghty
added
the
AzSDK Tools Agent
samvaity
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CustomizedCodeUpdateTool to resolve the spec repository root before calling tsp-client update, instead of forwarding the TypeSpec project directory directly. In the azsdk-cli codebase, that aligns regeneration with how spec-backed TypeSpec projects are structured.
Changes:
- Resolve
specRepoPathviaITypeSpecHelper.GetSpecRepoRootPath(...)before regeneration. - Apply the same repo-root forwarding in the Java post-patch regeneration path.
- Adjust the unit-test setup mock for
GetSpecRepoRootPath.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/TypeSpec/CustomizedCodeUpdateTool.cs |
Switches regen calls to use resolved spec repo root in both main and Java post-patch flows. |
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Tools/TypeSpec/CustomizedCodeUpdateToolTests.cs |
Updates the default ITypeSpecHelper mock used by CustomizedCodeUpdateTool tests. |
…resolution tests Agent-Logs-Url: https://github.com/Azure/azure-sdk-tools/sessions/33d4d0d6-f348-4041-a855-95feacaabb4a Co-authored-by: samvaity <16845631+samvaity@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/azure-sdk-tools/sessions/33d4d0d6-f348-4041-a855-95feacaabb4a Co-authored-by: samvaity <16845631+samvaity@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
raych1
approved these changes
May 6, 2026
Member
Author
|
@m-redding This resolves the timeout issue as well, since previously the tsp-client was pointing to the root repository at /azure-rest-api-specs. I tested this and confirmed it works for Java. |
Member
|
I'm no longer seeing the timeout so that one is fixed by this, but I'm still seeing the same problem with the path: it still gets confused about what the right input is. It did end up getting it right on the second try but have yet to see it get it right on the first try. I would say this improves the experience from "the LLM can't figure out the right inputs at all" to "the LLM can figure out the input eventually", but it's not at "the LLM can usually call the tool correctly on the first try". I'm not sure what the ultimate goal is tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverages the path resolution logic already used successfully in SdkGenerationTool to fix path resolution issues on CustomizeSDK Tooling
Closes: #15437