Skip to content

Add safe attribute helper to SafeDebug #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025
Merged

Conversation

heaths
Copy link
Member

@heaths heaths commented May 15, 2025

No description provided.

heaths and others added 2 commits May 15, 2025 01:33
They should've been before, but I realized I wasn't propagating the errors up and had to make significant changes to do so.
@heaths
Copy link
Member Author

heaths commented May 15, 2025

Making this a draft for now because I think, instead of copying the pattern we have with the Model derive macro - which @analogrelay is removing - I want to see if it's cleaner w.r.t. error handling to implement Parse as I did for azure_core_test_macros. This works, though.

Copy link
Member

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't approve because it's still draft, but I think this is looking good. We'll be moving all our types to SafeDebug and definitely have a lot of "safe" fields, so I'd love to get this in soon!

@heaths heaths marked this pull request as ready for review May 16, 2025 20:57
@heaths heaths enabled auto-merge (squash) May 16, 2025 20:57
@heaths heaths merged commit 258fca7 into Azure:main May 16, 2025
18 checks passed
@heaths heaths deleted the safe-debug-attr branch May 16, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants