Skip to content

Delete azure_identity dead code #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Delete azure_identity dead code #2603

merged 2 commits into from
May 14, 2025

Conversation

chlowell
Copy link
Member

Closes #2281

@github-actions github-actions bot added the Azure.Identity The azure_identity crate label May 13, 2025
@chlowell chlowell marked this pull request as ready for review May 13, 2025 20:59
@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 20:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dead code and related dependencies from the azure_identity SDK, cleaning up unused modules and functions.

  • Deleted unused modules: refresh_token, oauth2_http_client, chained_token_credential, and authorization_code_flow.
  • Removed the dead clear function from the token cache and purged the oauth2 dependency from project configuration.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/identity/azure_identity/src/refresh_token.rs Removed the refresh token functionality which is no longer used.
sdk/identity/azure_identity/src/oauth2_http_client.rs Deleted the unused oauth2 HTTP client adapter.
sdk/identity/azure_identity/src/lib.rs Removed module references to the deleted dead code files.
sdk/identity/azure_identity/src/credentials/cache.rs Removed the unused clear() function from the token cache.
sdk/identity/azure_identity/src/chained_token_credential.rs Deleted the chained token credential module as it was not in use.
sdk/identity/azure_identity/src/authorization_code_flow.rs Removed the authorization code flow module that is deprecated.
sdk/identity/azure_identity/Cargo.toml Removed the oauth2 dependency from the azure_identity Cargo.toml.
eng/dict/crates.txt Removed oauth2 from the list of crate dependencies.
Cargo.toml Removed the oauth2 dependency from the root Cargo.toml.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one suggestion, but nothing blocking.

@chlowell chlowell merged commit 6eb1861 into Azure:main May 14, 2025
32 checks passed
@chlowell chlowell deleted the deadcode branch May 14, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity The azure_identity crate
Projects
Development

Successfully merging this pull request may close these issues.

Use or remove any dead_code in azure_identity
2 participants