[AutoRelease] t2-appconfiguration-2025-05-22-48307(can only be merged by SDK owner) #41256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the App Configuration management SDK to a new beta release (5.0.0b1) and modernizes client and operations code with improved typing, serialization helpers, and endpoint discovery.
- Bump version to 5.0.0b1 and update Autorest/Python tool versions
- Add
Serializer/Deserializerimports, annotateself._client,self._config, and unifyerror_maptyping - Change list operation return types to
AsyncItemPaged, resolvebase_urlviaget_arm_endpoints, update defaultapi_version
Reviewed Changes
Copilot reviewed 85 out of 85 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azure/mgmt/appconfiguration/aio/_app_configuration_management_client.py | Use settings + get_arm_endpoints for default base_url |
| azure/mgmt/appconfiguration/aio/operations/_configuration_stores_operations.py | Insert serialization helpers and pass response_headers to LRO |
| azure/mgmt/appconfiguration/aio/operations/_snapshots_operations.py | Typed fields, moved imports, changed MutableMapping declaration |
| azure/mgmt/appconfiguration/_configuration.py | Default api_version updated to "2024-06-15-preview" |
| azure/mgmt/appconfiguration/_version.py | Bumped VERSION to "5.0.0b1" |
Comments suppressed due to low confidence (1)
sdk/appconfiguration/azure-mgmt-appconfiguration/azure/mgmt/appconfiguration/aio/operations/_snapshots_operations.py:1
- The removal of
# pylint: disable=too-many-lines,too-many-statementsat the top may trigger lint errors for large generated files. Consider re-adding or updating the disable directive.
# coding=utf-8
| @@ -1,16 +1,17 @@ | |||
| # pylint: disable=too-many-lines,too-many-statements | |||
| # pylint: disable=too-many-lines | |||
There was a problem hiding this comment.
Only too-many-lines is disabled but too-many-statements is still active, which may cause lint failures on this generated file. Consider disabling both.
Suggested change
| # pylint: disable=too-many-lines | |
| # pylint: disable=too-many-lines, too-many-statements |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6220
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=967
BuildTargetingString
azure-mgmt-appconfiguration
Skip.CreateApiReview