-
Notifications
You must be signed in to change notification settings - Fork 3k
[Core] Update aiohttp transport timeout errors #41227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also catch asyncio.TimeoutError
in AioHttpStreamDownloadGenerator
. Should we apply similar logic there as well?
This is a good question - I will double check. Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @annatisch for fixing this, appreciate your work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a changelog entry?
Yes. |
Fixes #39448
This PR makes two changes:
ConnectionTimeoutError
was added to aiohttp in v3.10, this patch checks for the new error type, and raises a retriableServiceRequestTimeoutError
in such cases.ServiceResponseError
with the more specific child classServiceResponseTimeoutError
.