[Provisioning.PostgreSql] Add PostgreSQL FlexibleServer versions 17 and 18#56212
Open
ArcturusZhang wants to merge 6 commits intoAzure:mainfrom
Open
[Provisioning.PostgreSql] Add PostgreSQL FlexibleServer versions 17 and 18#56212ArcturusZhang wants to merge 6 commits intoAzure:mainfrom
ArcturusZhang wants to merge 6 commits intoAzure:mainfrom
Conversation
ArcturusZhang
force-pushed
the
fix/postgresql-flexibleserver-version-17-18
branch
2 times, most recently
from
cb4fb26 to
ac67fb0
Compare
- Update Azure.ResourceManager.PostgreSql package version to 1.4.1 in eng/Packages.Data.props - Regenerate provisioning library using the generator with --filter PostgreSql - Adds PostgreSQL versions 17 and 18 to PostgreSqlFlexibleServerVersion enum - Fix schema generation conflict when a leaf property path is a prefix of another property path (e.g., 'properties' vs 'properties.administratorLogin') - Suppress CS0618 warning for deprecated ActiveDirectoryAdministratorResource Fixes Azure#55583
ArcturusZhang
force-pushed
the
fix/postgresql-flexibleserver-version-17-18
branch
from
ac67fb0 to
6de3453
Compare
- Order PostgreSqlFlexibleServerVersion enum to preserve Sixteen=5 ordinal - Rename PrivateEndpointConnections to PrivateEndpointConnectionResources - Add backward-compatible PrivateEndpointConnections property and Data type - Add ApiCompatBaseline for DataMember attribute changes on ReadReplicaPromoteMode and ReplicationPromoteOption
ArcturusZhang
requested review from
a team,
ArthurMa1978,
jorgerangel-msft,
jsquire and
m-nash
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure.Provisioning.PostgreSql package by bumping the underlying Azure.ResourceManager.PostgreSql dependency and regenerating the provisioning surface to include new PostgreSQL Flexible Server capabilities (notably versions 17 and 18), along with a small generator fix for schema generation conflicts and some backward-compatibility shims.
Changes:
- Bumped
Azure.ResourceManager.PostgreSqldependency and regenerated the PostgreSQL provisioning library. - Added backward-compat surface for renamed flexible server private endpoint connections property.
- Updated generator schema-tree building to handle prefix-path conflicts.
Reviewed changes
Copilot reviewed 10 out of 86 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/Packages.Data.props | Updates Azure.ResourceManager.PostgreSql dependency version. |
| sdk/provisioning/Generator/src/Specifications/PostgreSqlSpecification.cs | Customizations for regen (enum ordering, backward compat rename, warning suppression). |
| sdk/provisioning/Generator/src/Model/Specification.Schema.cs | Adjusts schema-tree generation for conflicting property paths. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/CHANGELOG.md | Notes regeneration and new server versions. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/ApiCompatBaseline.txt | Adds API compat suppressions for removed enum attributes. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/api/Azure.Provisioning.PostgreSql.netstandard2.0.cs | Updates public API listing for netstandard2.0. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/api/Azure.Provisioning.PostgreSql.net8.0.cs | Updates public API listing for net8.0. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/api/Azure.Provisioning.PostgreSql.net10.0.cs | Updates public API listing for net10.0. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/BackwardCompatible/PostgreSqlFlexibleServer.cs | Adds hidden legacy PrivateEndpointConnections property. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/BackwardCompatible/Models/PostgreSqlFlexibleServersPrivateEndpointConnectionData.cs | Marks legacy data model as hidden/obsolete in docs. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServer.cs | Regenerated flexible server resource (new API version, new properties, renamed PE connections). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServersPrivateEndpointConnection.cs | Regenerated PE connection resource for flexible servers. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServerMicrosoftEntraAdministrator.cs | Adds Microsoft Entra administrator resource type (new). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlMigration.cs | Regenerated migration resource (API version + docs updates). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServerActiveDirectoryAdministrator.cs | Regenerated AAD admin resource (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServerBackup.cs | Regenerated backup resource (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServerConfiguration.cs | Regenerated configuration resource (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServerDatabase.cs | Regenerated database resource (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFlexibleServerFirewallRule.cs | Regenerated firewall rule resource (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlPrivateEndpointConnection.cs | Regenerated private endpoint connection resource. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlServer.cs | Regenerated single server resource (base property definition call). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlServerAdministrator.cs | Regenerated administrator resource. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlServerKey.cs | Regenerated server key resource. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlServerSecurityAlertPolicy.cs | Regenerated security alert policy resource. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlVirtualNetworkRule.cs | Regenerated VNet rule resource. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlFirewallRule.cs | Regenerated firewall rule resource (base property definition call). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlDatabase.cs | Regenerated database resource (base property definition call). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlConfiguration.cs | Regenerated configuration resource (base property definition call). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/ServerThreatProtectionSettingsModel.cs | Regenerated advanced threat protection settings (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/VirtualEndpoint.cs | Regenerated virtual endpoint resource (API version changes). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerVersion.cs | Adds versions 17/18 enum members. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/ReadReplicaPromoteMode.cs | Regenerated promote mode enum (attributes removed). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/ReplicationPromoteOption.cs | Regenerated promote option enum (attributes removed). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServersReplica.cs | Regenerated replica model (docs updated). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServersStorageType.cs | Adds UltraSSD storage type enum value. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerIdentityType.cs | Adds combined SystemAssigned+UserAssigned identity enum value. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerUserAssignedIdentity.cs | Adds PrincipalId to identity model. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerClusterProperties.cs | Adds cluster properties model (new). |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerDataEncryption.cs | Updates data encryption model docs. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerState.cs | Adds additional server state enum values. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerConfigurationDataType.cs | Adds String/Set configuration data types. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServersSourceType.cs | Adds many new migration source types. |
| sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/* | Numerous doc wording updates and minor enum/model expansions from regeneration. |
...ioning/Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerVersion.cs
Show resolved
Hide resolved
sdk/provisioning/Generator/src/Specifications/PostgreSqlSpecification.cs
Show resolved
Hide resolved
sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/ReadReplicaPromoteMode.cs
Show resolved
Hide resolved
sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/ReadReplicaPromoteMode.cs
Show resolved
Hide resolved
sdk/provisioning/Azure.Provisioning.PostgreSql/src/ApiCompatBaseline.txt
Show resolved
Hide resolved
Comment on lines
+12
to
14
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| public class PostgreSqlSpecification() : | ||
| Specification("PostgreSql", typeof(PostgreSqlExtensions)) |
There was a problem hiding this comment.
#pragma warning disable CS0618 is applied at file scope but never restored, which can hide unrelated obsolete-API warnings added later in this file. Other specifications scope this pragma tightly with a matching #pragma warning restore (e.g., around the specific obsolete usages).
sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/Models/ReplicationPromoteOption.cs
Show resolved
Hide resolved
sdk/provisioning/Azure.Provisioning.PostgreSql/src/Generated/PostgreSqlMigration.cs
Show resolved
Hide resolved
...Azure.Provisioning.PostgreSql/src/Generated/Models/PostgreSqlFlexibleServerDataEncryption.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regenerate the Azure.Provisioning.PostgreSql library from the updated \Azure.ResourceManager.PostgreSql\ 1.4.0 package, which adds PostgreSQL versions 17 and 18 to the \PostgreSqlFlexibleServerVersion\ enum.
Changes
Fixes #55583