Update `Azure.ResourceManager.AppContainers` to `2025-02-02-preview` by najian · Pull Request #50236 · Azure/azure-sdk-for-net

najian · 2025-05-23T06:47:57Z

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot

Pull Request Overview

Adds the 2025-02-02-preview version of the Container Apps SDK and adjusts the ContainerAppBillingMeterProperties class.

Removes the setter from the Category property
Makes Category read-only

ArcturusZhang · 2025-05-23T08:34:14Z

+        System.Collections.Generic.IEnumerator<Azure.ResourceManager.AppContainers.BuildResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppContainers.BuildResource>.GetEnumerator() { throw null; }
+        System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
+    }
+    public partial class BuildResourceData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.BuildResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.BuildResourceData>


how should we comprehend a "BuildResource"?
I think we need to rename this, should this be AppBuild?

ArcturusZhang · 2025-05-23T08:35:10Z

@@ -186,8 +442,8 @@ protected ContainerAppConnectedEnvironmentCertificateResource() { }
        Azure.ResourceManager.AppContainers.ContainerAppCertificateData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppCertificateData>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppCertificateData>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppCertificateData>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
-        public virtual Azure.Response<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentCertificateResource> Update(Azure.ResourceManager.AppContainers.Models.ContainerAppCertificatePatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentCertificateResource>> UpdateAsync(Azure.ResourceManager.AppContainers.Models.ContainerAppCertificatePatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public virtual Azure.ResourceManager.ArmOperation<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentCertificateResource> Update(Azure.WaitUntil waitUntil, Azure.ResourceManager.AppContainers.Models.ContainerAppCertificatePatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }


here is a breaking change.
we should introduce the removed overload back.
its implementation could just call this new one.

ArcturusZhang · 2025-05-23T08:36:02Z

    {
        public static readonly Azure.Core.ResourceType ResourceType;
        protected ContainerAppConnectedEnvironmentDaprComponentResource() { }
-        public virtual Azure.ResourceManager.AppContainers.ContainerAppDaprComponentData Data { get { throw null; } }
+        public virtual Azure.ResourceManager.AppContainers.ConnectedEnvironmentDaprComponentData Data { get { throw null; } }


so we need to rename this model back

ArcturusZhang · 2025-05-23T08:38:25Z

@@ -311,7 +573,7 @@ protected ContainerAppConnectedEnvironmentStorageCollection() { }
    public partial class ContainerAppConnectedEnvironmentStorageData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentStorageData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentStorageData>
    {
        public ContainerAppConnectedEnvironmentStorageData() { }
-        public Azure.ResourceManager.AppContainers.Models.ContainerAppAzureFileProperties ConnectedEnvironmentStorageAzureFile { get { throw null; } set { } }
+        public Azure.ResourceManager.AppContainers.Models.ConnectedEnvironmentStorageProperties Properties { get { throw null; } set { } }


Emmm why would we have this change?

ArcturusZhang · 2025-05-23T08:39:48Z

+        System.Collections.Generic.IEnumerator<Azure.ResourceManager.AppContainers.ContainerAppsBuildResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppContainers.ContainerAppsBuildResource>.GetEnumerator() { throw null; }
+        System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
+    }
+    public partial class ContainerAppsBuildResourceData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.ContainerAppsBuildResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppsBuildResourceData>


if possible I think we should remove the word resource from this model

ArcturusZhang · 2025-05-23T08:40:40Z

+        System.Collections.Generic.IEnumerator<Azure.ResourceManager.AppContainers.ContainerAppsPatchResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppContainers.ContainerAppsPatchResource>.GetEnumerator() { throw null; }
+        System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
+    }
+    public partial class ContainerAppsPatchResourceData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.ContainerAppsPatchResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppsPatchResourceData>


we should remove the word Resource from this model's name

ArcturusZhang · 2025-05-23T08:42:50Z

    }
    [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
-    public readonly partial struct ContainerAppAccessMode : System.IEquatable<Azure.ResourceManager.AppContainers.Models.ContainerAppAccessMode>
+    public readonly partial struct BuilderProvisioningState : System.IEquatable<Azure.ResourceManager.AppContainers.Models.BuilderProvisioningState>


we should rename this to AppContainersBuilderProvisioningState

ArcturusZhang · 2025-05-23T08:43:27Z

    [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
-    public readonly partial struct ContainerAppActiveRevisionsMode : System.IEquatable<Azure.ResourceManager.AppContainers.Models.ContainerAppActiveRevisionsMode>
+    public readonly partial struct BuildProvisioningState : System.IEquatable<Azure.ResourceManager.AppContainers.Models.BuildProvisioningState>


we should rename this to AppContainersBuildProvisioningState

ArcturusZhang · 2025-05-23T08:43:45Z

        public override string ToString() { throw null; }
    }
-    public partial class ContainerAppAllowedPrincipals : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.ContainerAppAllowedPrincipals>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerAppAllowedPrincipals>
+    [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
+    public readonly partial struct BuildStatus : System.IEquatable<Azure.ResourceManager.AppContainers.Models.BuildStatus>


we should prepend the RP name

ArcturusZhang · 2025-05-23T08:43:56Z

+        public static bool operator !=(Azure.ResourceManager.AppContainers.Models.BuildStatus left, Azure.ResourceManager.AppContainers.Models.BuildStatus right) { throw null; }
+        public override string ToString() { throw null; }
+    }
+    public partial class BuildToken : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.BuildToken>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.BuildToken>


ArcturusZhang · 2025-05-23T08:45:45Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerExecutionStatus>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerExecutionStatus>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class ContainerRegistry : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.ContainerRegistry>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerRegistry>


this name collides with the namespace of another RP, we should rename it.

ArcturusZhang · 2025-05-23T08:46:49Z

@@ -3729,6 +5217,18 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer
        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EncryptionSettings>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EncryptionSettings>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
    }
+    public partial class EnvironmentVariable : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.EnvironmentVariable>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EnvironmentVariable>


we need to prepend something to this name

ArcturusZhang · 2025-05-23T08:47:52Z

@@ -3742,6 +5242,222 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer
        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EventTriggerConfiguration>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EventTriggerConfiguration>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
    }
+    public partial class Header : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.Header>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.Header>


this name only has one word, we need to specify.

ArcturusZhang · 2025-05-23T08:51:44Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.Header>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.Header>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class HeaderMatch : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>


we should also introduce a more specifc name

ArcturusZhang · 2025-05-23T08:54:26Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class HttpConnectionPool : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>


this is very likely to collide with system types, we need to specify its name

ArcturusZhang · 2025-05-23T08:54:42Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class HttpGet : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpGet>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpGet>


this is very likely to collide with system types, we need to specify its name

ArcturusZhang · 2025-05-23T09:00:33Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpGet>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpGet>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class HttpRetryPolicy : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>


this is very likely to collide with core types, we need to specify its name

ArcturusZhang · 2025-05-23T09:01:17Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class HttpRoute : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpRoute>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRoute>


this is very likely to collide with system types, we need to specify its name

ArcturusZhang · 2025-05-23T09:02:11Z

+        string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRouteConfigProperties>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+        System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRouteConfigProperties>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
+    }
+    public partial class HttpRouteMatch : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpRouteMatch>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRouteMatch>


this is very likely to collide with system types, we need to specify its name

…02-preview

github-actions · 2025-08-01T05:14:30Z

Hi @najian. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions · 2025-08-08T08:40:42Z

Hi @najian. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

Add 2025-02-02-preview SDK

adfd9db

Copilot AI review requested due to automatic review settings May 23, 2025 06:47

najian requested review from ArcturusZhang and ArthurMa1978 as code owners May 23, 2025 06:47

github-actions Bot added the Mgmt This issue is related to a management package. label May 23, 2025

Copilot AI reviewed May 23, 2025

View reviewed changes

Comment thread ...nerapps/Azure.ResourceManager.AppContainers/src/Custom/ContainerAppBillingMeterProperties.cs

ArcturusZhang reviewed May 23, 2025

View reviewed changes

ArcturusZhang changed the title ~~Add 2025-02-02-preview SDK~~ Update Azure.ResourceManager.AppContainers to 2025-02-02-preview May 24, 2025

ArcturusZhang and others added 3 commits May 24, 2025 15:17

a few updates

b2163fa

Merge remote-tracking branch 'origin/main' into naji/release-2025-02-…

dffc58d

…02-preview

Rename ConnectedEnvironmentDaprComponent

82d77d6

github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Aug 1, 2025

github-actions Bot closed this Aug 8, 2025

Conversation

najian commented May 23, 2025

Contributing to the Azure SDK

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 1, 2025

Uh oh!

github-actions Bot commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants