-
Notifications
You must be signed in to change notification settings - Fork 5k
Updated Azure.Provisioning.* to the latest releases (including previews) #50227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates Azure.Provisioning.* packages to the latest releases (including previews) and switches all provisioning projects from ProjectReferences to PackageReferences, regenerating impacted code.
- Handwritten changes add placeholder properties with
EditorBrowsable(Never)
attributes andNotSupportedException
for future extensibility. - Numerous CosmosDB and EventGrid model and service classes were scaffolded or updated.
eng/Packages.Data.props
was updated with new version numbers for Resource Manager packages.
Reviewed Changes
Copilot reviewed 642 out of 642 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
sdk/provisioning/Azure.Provisioning.EventGrid/src/EventGridTopic.cs | Adds placeholder properties (ExtendedLocation, Kind, SkuName) with EditorBrowsable(Never) and throws NotSupportedException . |
sdk/provisioning/Azure.Provisioning.EventGrid/src/EventGridDomain.cs | Adds placeholder SkuName property with EditorBrowsable(Never) and throws NotSupportedException . |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/MongoCluster.cs | Marks MongoCluster as hidden from editor (EditorBrowsable(Never) ). |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/NodeKind.cs | Hides NodeKind enum from editor (EditorBrowsable(Never) ). |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/NodeGroupSpec.cs | Removes auto-generated header and cleans using directives. |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/MongoClusterStatus.cs | Hides MongoClusterStatus enum from editor (EditorBrowsable(Never) ). |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/MongoClusterRestoreParameters.cs | Hides MongoClusterRestoreParameters class from editor (EditorBrowsable(Never) ). |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/ErrorResponse.cs | Introduces ErrorResponse wrapper class. |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/DataTransferJobProperties.cs | Adds Error property exposing ErrorResponse . |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/CosmosDBProvisioningState.cs | Hides CosmosDBProvisioningState enum from editor (EditorBrowsable(Never) ). |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/Models/CosmosDBFirewallRule.cs | Hides CosmosDBFirewallRule class from editor (EditorBrowsable(Never) ). |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/DataTransferJobGetResult.cs | Adds Error property to DataTransferJobGetResult . |
sdk/provisioning/Azure.Provisioning.CosmosDB/src/CosmosDBService.cs | Adds placeholder Properties with EditorBrowsable(Never) and throws NotSupportedException . |
eng/Packages.Data.props | Bumps many Azure.ResourceManager.* package versions to recent stable and preview releases. |
Comments suppressed due to low confidence (3)
sdk/provisioning/Azure.Provisioning.EventGrid/src/EventGridTopic.cs:23
- Consider using NotImplementedException instead of NotSupportedException for stub members, as NotImplementedException more clearly indicates the method is a placeholder.
get => throw new NotSupportedException("TODO: Needs to be implemented using extensibility API.");
sdk/provisioning/Azure.Provisioning.EventGrid/src/EventGridDomain.cs:22
- Consider using NotImplementedException for these stub getters to more accurately signal future implementation work.
get => throw new NotSupportedException("TODO: Needs to be implemented using extensibility API.");
sdk/provisioning/Azure.Provisioning.CosmosDB/src/CosmosDBService.cs:22
- Stub-only members typically use NotImplementedException; it may improve clarity over NotSupportedException.
get => throw new NotSupportedException("TODO: Needs to be implemented using extensibility API.");
public BicepValue<EventGridSku> SkuName | ||
{ | ||
get => throw new NotSupportedException("TODO: Needs to be implemented using extensibility API."); | ||
set => throw new NotSupportedException("TODO: Needs to be implemented using extensibility API."); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emmm would we need follow ups for this before our next release?
It makes me kind of uncomfortable to update an existing API to "not working"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will get patched to use the new dynamic API in the next couple of days. Leaving former preview APIs slightly broken for a couple of days is worth it to avoid more aggressive refactoring of property definition to make it hackable from partial classes.
There was an error handling pipeline event 413d1f98-dd03-49f1-a3f6-6a0e280e471c. |
These APIs are removed in the new versions therefore we added
|
<PackageReference Update="Azure.ResourceManager.KeyVault" Version="1.3.2" /> | ||
<PackageReference Update="Azure.ResourceManager.Kubernetes" Version="1.0.0-beta.5" /> | ||
<PackageReference Update="Azure.ResourceManager.KubernetesConfiguration" Version="1.2.0" /> | ||
<PackageReference Update="Azure.ResourceManager.ManagedServiceIdentities" Version="1.3.0-beta.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use stable version here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we want to release stable version, we should change them to stable
… that made AccountName virtual
Please note there are two commits. The first makes all the handwritten changes and the second is just a noisy regeneration.
This also changes everything in Azure.Provisioning.* to use PackageReferences instead of ProjectReferences.