FixGetRecordingTest #50222
Open
FixGetRecordingTest #50222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Enables and augments the live GetRecordingTest by removing its skip, adding playback and delays to generate valid recordings, introduces corresponding recorded JSON fixtures, and updates the asset tag.
- Un-commented the
[Ignore]onGetRecordingTest, added audio playback viaPlayToAllAsyncand fixed delays before stopping and fetching recordings. - Added new recorded test fixtures (
GetRecordingTest.jsonandGetRecordingTestAsync.json) capturing the full sequence of call events. - Bumped the
Taginassets.jsonto reference the updated recorded fixtures.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/communication/Azure.Communication.CallAutomation/tests/SessionRecordedEvents/CallRecordingAutomatedLiveTests/GetRecordingTestAsync.json | New JSON fixture for asynchronous recording retrieval events. |
| sdk/communication/Azure.Communication.CallAutomation/tests/SessionRecordedEvents/CallRecordingAutomatedLiveTests/GetRecordingTest.json | New JSON fixture for synchronous recording retrieval events. |
| sdk/communication/Azure.Communication.CallAutomation/tests/CallRecordings/CallRecordingAutomatedLiveTests.cs | Enabled GetRecordingTest, added playback, delays, and updated logic. |
| sdk/communication/Azure.Communication.CallAutomation/assets.json | Updated Tag to match new recorded test assets. |
...n/Azure.Communication.CallAutomation/tests/CallRecordings/CallRecordingAutomatedLiveTests.cs
Outdated
Show resolved
Hide resolved
...n/Azure.Communication.CallAutomation/tests/CallRecordings/CallRecordingAutomatedLiveTests.cs
Show resolved
Hide resolved
| @@ -0,0 +1,64 @@ | |||
| { | |||
| "entries": [ | |||
There was a problem hiding this comment.
[nitpick] The two JSON fixtures for sync and async tests share almost identical data; consider extracting common event sequences into a shared helper or fixture to reduce duplication.
Copilot uses AI. Check for mistakes.
amariwest-msft
force-pushed
the
amariwest/FixGetRecordingTest
branch
from
219523c to
94f2fd1
Compare
amariwest-msft
force-pushed
the
amariwest/FixGetRecordingTest
branch
from
bf2c5e7 to
94f2fd1
Compare
amariwest-msft
force-pushed
the
amariwest/FixGetRecordingTest
branch
from
d8569ce to
94f2fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.