Disable outbound access #50218
Open
Disable outbound access #50218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
requested review from
seanmcc-msft,
amnguye,
jaschrep-msft,
tg-msft,
jalauzon-msft and
nickliu-msft
as code owners
|
/azp run net - storage - tests |
There was a problem hiding this comment.
Pull Request Overview
This PR disables default outbound network access for virtual networks as required by SFI-NS2.6.1.
- Adds the "defaultoutboundaccess": false property to subnet configurations in the test resources.
Comments suppressed due to low confidence (1)
sdk/storage/test-resources.json:436
- [nitpick] Verify if the property name 'defaultoutboundaccess' intentionally differs from the camelCase naming used in 'addressPrefix', or consider aligning it for consistency if not dictated by external API requirements.
"defaultoutboundaccess": false
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of SFI-NS2.6.1 we need to disable default outbound network access for vnets.