Repository navigation
Add MoveParticipants API and Event Handling Support - #50197
Merged
Vinothini Dharmaraj (v-dharmarajv) merged 5 commits intoJun 11, 2025
Merged
Vinothini Dharmaraj (v-dharmarajv) merged 5 commits into
Vinothini Dharmaraj (v-dharmarajv) merged 5 commits into
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Vinothini Dharmaraj (v-dharmarajv)
marked this pull request as ready for review
June 5, 2025 21:57
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for moving participants between calls in the Call Automation .NET SDK by adding new synchronous and asynchronous MoveParticipants APIs and their associated event handling.
- Added MoveParticipants APIs, including overloads that take options and separate parameters.
- New models (MoveParticipantsResult, MoveParticipantsOptions) and event types (MoveParticipantSucceeded, MoveParticipantFailed) were introduced.
- Test coverage and API definitions were updated across the SDK and API surface.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/CallConnections/CallConnectionTests.cs | Added tests validating successful and error scenarios of the MoveParticipants methods. |
| src/Models/MoveParticipantsResult.cs | Introduced a result model with methods to wait for participant move events. |
| src/Models/MoveParticipantsResponseInternal.cs | Updated to use CodeGenModel attributes for code generation. |
| src/Models/MoveParticipantsRequestInternal.cs | Added a new partial class for the request model (requires completeness through code generation). |
| src/Models/MoveParticipantsOptions.cs | Introduced options to configure move participants operations. |
| src/Models/Events/* | Added internal and public event types for MoveParticipantSucceeded/Failed events. |
| src/CallConnection.cs | Added MoveParticipants API implementations and request creation logic. |
| api/*.cs | Updated API definitions to reflect the new MoveParticipants operations. |
Comments suppressed due to low confidence (2)
sdk/communication/Azure.Communication.CallAutomation/src/Models/MoveParticipantsRequestInternal.cs:10
- The partial class MoveParticipantsRequestInternal is currently empty but is instantiated with constructor parameters in CallConnection.CreateMoveParticipantsRequest. Please verify that the remaining partial definition (or code generation) provides the necessary constructor and properties.
internal partial class MoveParticipantsRequestInternal
sdk/communication/Azure.Communication.CallAutomation/src/CallConnection.cs:612
- The MoveParticipants API accepts multiple participants (IEnumerable) while the event result (MoveParticipantEventResult) returns a single TargetParticipant. Please confirm that this behavior is intended and document it accordingly if only one participant is expected to be processed in the event result.
result.SetEventProcessor(EventProcessor, CallConnectionId, request.OperationContext);
1 of 3 tasks
huachuandeng
approved these changes
Jun 10, 2025
Vinothini Dharmaraj (v-dharmarajv)
approved these changes
Jun 11, 2025
Vinothini Dharmaraj (v-dharmarajv)
deleted the
users/v-vkaluri/feature/moveParticipant
branch
June 11, 2025 23:15
Jesse Squire (jsquire)
pushed a commit
to JonathanCrd/azure-sdk-for-net
that referenced
this pull request
Jun 23, 2025
* Adding the Move Participants to Call Connection * Updated the Move Participants, removed the Live test as it cannot be tested for non p2p scenarios * Addressing PR comments: By adding the FromCall in MoveParticipantsEventResult
Srinivasa Kaluri (v-vkaluri)
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jun 30, 2025
### Packages impacted by this PR Communication-Call-Automation ### Issues associated with this PR ### Describe the problem that is addressed by this PR Implements moveParticipants method for Azure Communication Services Call Automation SDK, enabling movement of participants between different calls. Follows existing SDK patterns with MoveParticipantSucceeded/MoveParticipantFailed events (singular per participant) and fromCall tracking for source call identification. Includes comprehensive interfaces (MoveParticipantsOptions, MoveParticipantsResult), event processing integration, and full test coverage with unit and live integration tests. API: moveParticipants(targetParticipants: CommunicationIdentifier[], options: MoveParticipantsOptions). Added unit tests for move participants. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ Azure/azure-sdk-for-net#50197 Azure/azure-sdk-for-python#41448 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the Move Participant feature in the Azure Communication Services Call Automation .NET SDK.
Changes Include:
Correlation Id for reference: 55b23437-747e-4f0e-b2af-0ef376757436
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.