Sync eng/common directory with azure-sdk-tools for PR 10681 #50187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This pull request syncs the eng/common directory with updates from azure-sdk-tools, specifically in the MCP script.
- Added a new parameter and default for RunDirectory
- Modified the Start-Process call to include a working directory
Comments suppressed due to low confidence (1)
eng/common/mcp/azure-sdk-mcp.ps1:60
- [nitpick] Verify that the resolved RunDirectory exists and is accessible before starting the process, or consider adding error handling in case it is not valid.
Start-Process -WorkingDirectory $RunDirectory -FilePath $exe -ArgumentList 'start' -NoNewWindow -Wait
benbp
approved these changes
May 21, 2025
azure-sdk
force-pushed
the
sync-eng/common-benbp/mcp-runner-dir-10681
branch
from
869f29c to
8687444
Compare
benbp
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10681 See eng/common workflow