-
Notifications
You must be signed in to change notification settings - Fork 5k
[servicefabricmanagedclusters] sdk for 2025-03-01-preview api version #50184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nto user/iliu/2025-03-01-preview
* code customizations for UnknownPartition, UnknownScalingtrigger, UnknownServicePlacementPolicy, and UnknownScalingMechanism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces customization support for the 2025-03-01 preview of the Service Fabric Managed Clusters SDK by adding model factories and unknown‐type placeholders.
- Adds a model factory method for
ServiceFabricManagedApplicationData
to simplify test/mock construction. - Introduces internal
Unknown*
classes for handling unrecognized placement policies, scaling triggers, scaling mechanisms, and partition schemes. - Updates the
assets.json
tag to reflect the new preview build.
Reviewed Changes
Copilot reviewed 182 out of 182 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
ServiceFabricManagedApplicationData.cs | Add static factory method for ServiceFabricManagedApplicationData |
UnknownServicePlacementPolicy.cs | Add placeholder class for unknown placement policy models |
UnknownScalingTrigger.cs | Add placeholder class for unknown scaling trigger models |
UnknownScalingMechanism.cs | Add placeholder class for unknown scaling mechanism models |
UnknownPartition.cs | Add placeholder class for unknown partition scheme models |
assets.json | Bump asset tag to new preview identifier |
Comments suppressed due to low confidence (1)
sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Customization/Models/UnknownPartition.cs:10
- [nitpick] Class name 'UnknownPartition' does not clearly reflect the 'UnknownManagedServicePartitionScheme' model; consider renaming to 'UnknownPartitionScheme' or 'UnknownServicePartitionScheme' for consistency.
internal partial class UnknownPartition
managedIdentities?.ToList(), | ||
provisioningState, | ||
version, | ||
parameters, | ||
upgradePolicy, | ||
identity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameters 'identity' and 'managedIdentities' are swapped when calling the constructor; the 'identity' argument should be passed before 'provisioningState' and 'managedIdentities' last.
managedIdentities?.ToList(), | |
provisioningState, | |
version, | |
parameters, | |
upgradePolicy, | |
identity, | |
identity, | |
provisioningState, | |
version, | |
parameters, | |
upgradePolicy, | |
managedIdentities?.ToList(), |
Copilot uses AI. Check for mistakes.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a customization file I added to get the package to build. Please replace it with a validate/approved version from the .NET team.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.