Skip to content

[servicefabricmanagedclusters] sdk for 2025-03-01-preview api version #50184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

iliu816
Copy link
Member

@iliu816 iliu816 commented May 21, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 17:17
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 21, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces customization support for the 2025-03-01 preview of the Service Fabric Managed Clusters SDK by adding model factories and unknown‐type placeholders.

  • Adds a model factory method for ServiceFabricManagedApplicationData to simplify test/mock construction.
  • Introduces internal Unknown* classes for handling unrecognized placement policies, scaling triggers, scaling mechanisms, and partition schemes.
  • Updates the assets.json tag to reflect the new preview build.

Reviewed Changes

Copilot reviewed 182 out of 182 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ServiceFabricManagedApplicationData.cs Add static factory method for ServiceFabricManagedApplicationData
UnknownServicePlacementPolicy.cs Add placeholder class for unknown placement policy models
UnknownScalingTrigger.cs Add placeholder class for unknown scaling trigger models
UnknownScalingMechanism.cs Add placeholder class for unknown scaling mechanism models
UnknownPartition.cs Add placeholder class for unknown partition scheme models
assets.json Bump asset tag to new preview identifier
Comments suppressed due to low confidence (1)

sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Customization/Models/UnknownPartition.cs:10

  • [nitpick] Class name 'UnknownPartition' does not clearly reflect the 'UnknownManagedServicePartitionScheme' model; consider renaming to 'UnknownPartitionScheme' or 'UnknownServicePartitionScheme' for consistency.
internal partial class UnknownPartition

Comment on lines +51 to +56
managedIdentities?.ToList(),
provisioningState,
version,
parameters,
upgradePolicy,
identity,
Copy link
Preview

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters 'identity' and 'managedIdentities' are swapped when calling the constructor; the 'identity' argument should be passed before 'provisioningState' and 'managedIdentities' last.

Suggested change
managedIdentities?.ToList(),
provisioningState,
version,
parameters,
upgradePolicy,
identity,
identity,
provisioningState,
version,
parameters,
upgradePolicy,
managedIdentities?.ToList(),

Copilot uses AI. Check for mistakes.

Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.ServiceFabricManagedClusters

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a customization file I added to get the package to build. Please replace it with a validate/approved version from the .NET team.

@iliu816 iliu816 changed the title User/iliu/2025 03 01 preview [servicefabricmanagedclusters] sdk for 2025-03-01-preview api version May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants