Skip to content

Attempt at code generation for APC SDK #50180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SallyAnneBennett
Copy link
Member

Following https://eng.ms/docs/products/azure-developer-experience/develop/sdk-generate-mgmt-dotnet for APC, commands for generation appear to be working but the files aren't generated. Creating PR so team can investigate

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 15:15
@github-actions github-actions bot added Mgmt This issue is related to a management-plane library. Storage Storage Service (Queues, Blobs, Files) labels May 21, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Scaffolds the new ProgrammableConnectivity management SDK and integrates it into pipelines, while adjusting storage CI path excludes.

  • Registers sdk/programmableconnectivity in global and service-specific CI YAMLs
  • Adds project, test, sample, and documentation scaffolding for the new SDK
  • Modifies sdk/storage/ci.yml to adjust path exclusions

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/storage/ci.yml Added a duplicate exclude block in CI trigger
sdk/resourcemanager/ci.mgmt.yml Included programmableconnectivity in triggers
sdk/programmableconnectivity/ci.mgmt.yml New CI YAML for programmableconnectivity SDK
sdk/programmableconnectivity/Azure.ResourceManager.ProgrammableConnectivity/samples/Azure.ResourceManager.ProgrammableConnectivity.Samples.csproj Scaffolds sample project dependencies
sdk/programmableconnectivity/Azure.ResourceManager.ProgrammableConnectivity/README.md Initial README template
sdk/programmableconnectivity/Azure.ResourceManager.ProgrammableConnectivity/tests Added test environment and base class scaffolding
Comments suppressed due to low confidence (3)

sdk/programmableconnectivity/Azure.ResourceManager.ProgrammableConnectivity/tests/ProgrammableConnectivityManagementTestBase.cs:13

  • No actual test methods implemented under tests; add test cases covering core operations to validate SDK functionality.
    public class ProgrammableConnectivityManagementTestBase : ManagementRecordedTestBase<ProgrammableConnectivityManagementTestEnvironment>

sdk/programmableconnectivity/Azure.ResourceManager.ProgrammableConnectivity/samples/Azure.ResourceManager.ProgrammableConnectivity.Samples.csproj:4

  • [nitpick] Sample project should not include test frameworks like NUnit; it should reference only runtime dependencies. Remove test-specific packages from samples.
    <PackageReference Include="NUnit"  />

sdk/programmableconnectivity/Azure.ResourceManager.ProgrammableConnectivity/README.md:3

  • [nitpick] Placeholder description in README; provide a brief service overview to guide users.
**[Describe the service briefly first.]**

Comment on lines 18 to 19
exclude:
- sdk/storage/Azure.ResourceManager.Storage/
Copy link
Preview

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate exclude block inserted in the trigger paths section; this likely causes misconfiguration. Consolidate into a single exclude under paths.

Suggested change
exclude:
- sdk/storage/Azure.ResourceManager.Storage/

Copilot uses AI. Check for mistakes.

Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.ProgrammableConnectivity

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SallyAnneBennett :

Your account lacks the public membership to the Microsoft GitHub organization required of an internal contributor. Please adjust your membership visibility to mark it public.
More context can be found in the Azure SDK onboarding documentation and support is available in the associated Teams channel.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@@ -12,6 +12,8 @@ trigger:
- sdk/storage/Azure.Storage.DataMovement/
- sdk/storage/Azure.Storage.DataMovement.Blobs/
- sdk/storage/Azure.Storage.DataMovement.Files/
exclude:
- sdk/storage/Azure.ResourceManager.Storage/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted. You shouldn't be altering files outside of your /sdk area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants