Sync eng/common directory with azure-sdk-tools for PR 15515#38434
Closed
Sync eng/common directory with azure-sdk-tools for PR 15515#38434
Conversation
Rust's default HTTP stack - reqwest - does not support a self-signed TLS certificate. Instead, we split the CA out while retaining the old dotnet-devcert.crt public key PEM. dotnet-devcert.pfx is still the key pair for the server TLS certificate, but is signed by the separate CA. This should require no code changes to other languages' test-proxy implementations. Relates to Azure/azure-sdk-for-rust#4345
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs eng/common/testproxy certificate assets and tooling with the upstream azure-sdk-tools changes from Azure/azure-sdk-tools#15515, primarily around how the Test Proxy’s HTTPS dev certificate is configured/rotated.
Changes:
- Added a
rotate.shhelper to regenerate the localhost TLS cert chain and re-bundle intodotnet-devcert.pfx. - Updated TLS OpenSSL config (
localhost.conf) to generate a proper non-CA leaf cert and adjusted related certificate assets. - Introduced supporting CA config (
ca.conf) and a local.gitignorefor generated key/CSR/serial artifacts.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/testproxy/rotate.sh | New OpenSSL-based rotation script to regenerate CA/leaf certs and produce a PFX bundle for the Test Proxy. |
| eng/common/testproxy/localhost.crt | Adds/updates the committed localhost leaf certificate artifact. |
| eng/common/testproxy/localhost.conf | Adjusts OpenSSL leaf-cert extensions (notably CA:false) and adds header comments. |
| eng/common/testproxy/dotnet-devcert.crt | Updates the committed CA public certificate used for trust installation. |
| eng/common/testproxy/ca.conf | New OpenSSL config to generate the self-signed CA certificate. |
| eng/common/testproxy/.gitignore | Ignores generated key/CSR/serial files produced by rotation. |
Member
|
Investigating some potential issues in .NET that may exist elsewhere but don't want to keep these open forever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15515 See eng/common workflow