Skip to content

mgmt containerinstance , fix live test failures #47634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-huizhu2 merged 11 commits into from
Jan 8, 2026
Merged

mgmt containerinstance , fix live test failures #47634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae45bf3
test(container): disable failing test due to policy restriction
v-huizhu2 Dec 8, 2025
ea2cae2
feat(test): enable file share volume testing for container groups
v-huizhu2 Dec 23, 2025
2927af5
fix(test): update ContainerGroupTest to clarify Azure Storage limitat…
v-huizhu2 Dec 25, 2025
fe8fc1c
test(containerinstance): add tests for container group volume configu…
v-huizhu2 Jan 5, 2026
a792d38
fix(containerinstance): update test comment and remove outdated refer…
v-huizhu2 Jan 6, 2026
ebbe31e
chore(containerinstance): update assets tag
v-huizhu2 Jan 6, 2026
170b5c7
refactor(tests): remove unused storage manager from container instanc…
v-huizhu2 Jan 6, 2026
e470d05
chore(containerinstance): update assets tag
v-huizhu2 Jan 6, 2026
a7a101e
refactor(ContainerGroupTest): remove unused imports
v-huizhu2 Jan 6, 2026
557589a
Update sdk/containerinstance/azure-resourcemanager-containerinstance/…
v-huizhu2 Jan 6, 2026
c909297
Update sdk/containerinstance/azure-resourcemanager-containerinstance/…
v-huizhu2 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/containerinstance/azure-resourcemanager-containerinstance/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/containerinstance/azure-resourcemanager-containerinstance",
"Tag": "java/containerinstance/azure-resourcemanager-containerinstance_a0e5cc2e29"
"Tag": "java/containerinstance/azure-resourcemanager-containerinstance_cade898991"
}
27 changes: 26 additions & 1 deletion ...nstance/src/test/java/com/azure/resourcemanager/containerinstance/ContainerGroupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@

package com.azure.resourcemanager.containerinstance;

import com.azure.core.management.Region;
import com.azure.core.test.annotation.DoNotRecord;
import com.azure.resourcemanager.containerinstance.models.Container;
import com.azure.resourcemanager.containerinstance.models.ContainerAttachResult;
import com.azure.resourcemanager.containerinstance.models.ContainerExec;
import com.azure.resourcemanager.containerinstance.models.ContainerGroup;
import com.azure.core.management.Region;
import com.azure.resourcemanager.containerinstance.models.ContainerGroupRestartPolicy;
import com.azure.resourcemanager.containerinstance.models.ContainerHttpGet;
import com.azure.resourcemanager.containerinstance.models.ContainerProbe;
Expand All @@ -19,6 +19,7 @@
import com.azure.resourcemanager.resources.fluentcore.model.Accepted;
import com.azure.resourcemanager.resources.fluentcore.utils.ResourceManagerUtils;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.time.Duration;
Expand Down Expand Up @@ -210,8 +211,11 @@ public void testBeginCreate() {
}

// test contains a data-plane call
// Azure Storage doesn't support SMB mounting of file share using managed identity
// https://learn.microsoft.com/azure/container-instances/container-instances-volume-azure-files
@DoNotRecord(skipInPlayback = true)
@Test
@Disabled("This request was denied due to internal policy. Container Group requires that Storage Accounts is authenticated with managed identity, but Azure Storage doesn't support SMB mounting of file share using managed identity. ")
public void testBeginCreateWithFileShareVolume() {
String containerGroupName = generateRandomResourceName("container", 20);
Region region = Region.US_WEST3;
Expand All @@ -232,6 +236,27 @@ public void testBeginCreateWithFileShareVolume() {
Assertions.assertEquals(1, containerGroup.volumes().size());
}

@DoNotRecord(skipInPlayback = true)
@Test
public void testBeginCreateWithEmptyDirectoryVolume() {
String containerGroupName = generateRandomResourceName("container", 20);
Region region = Region.US_WEST3;

// create virtual network before creating container group
Accepted<ContainerGroup> acceptedContainerGroup = containerInstanceManager.containerGroups()
.define(containerGroupName)
.withRegion(region)
.withNewResourceGroup(rgName)
.withLinux()
.withPublicImageRegistryOnly()
.withEmptyDirectoryVolume("vol2")
.withContainerInstance("nginx", 80)
.withNewVirtualNetwork("10.0.0.0/24")
.beginCreate();
ContainerGroup containerGroup = acceptedContainerGroup.getSyncPoller().getFinalResult();
Assertions.assertEquals(1, containerGroup.volumes().size());
}

@Test
public void testCreateWithAutoGeneratedDomainNameLabelScope() {
String containerGroupName = generateRandomResourceName("container", 20);
Expand Down