Sync eng/common directory with azure-sdk-tools for PR 10593 #45280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use locally cloned repos to check github links to avoid rate-limiting.
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools as part of PR 10593, updating scripts to better handle link verification.
- Introduces a new parameter to support resolving GitHub links from a local clone.
- Adds conditional logic to use local GitHub clones for performance and rate limiting improvements.
- Trims cached link entries and ensures uniqueness when writing out validated links.
| @@ -72,6 +72,7 @@ param ( | |||
| [string] $userAgent, | |||
| [string] $inputCacheFile, | |||
| [string] $outputCacheFile, | |||
| [string] $localGithubClonedRoot = "", | |||
There was a problem hiding this comment.
[nitpick] Consider adding inline documentation for the new parameter '$localGithubClonedRoot' to clarify its intended usage.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10593 See eng/common workflow