Skip to content

mgmt, upgrade resources to 2025-03 #45276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

weidongxu-microsoft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 9, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-resources

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 9, 2025

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review May 9, 2025 10:01
@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 10:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades and extends the resources SDK to support the 2025-03 API version while introducing new properties and JSON serialization logic for deployment extensions and related components. Key changes include:

  • Updating the API version from "2024-11-01" to "2025-03-01".
  • Adding new properties (such as extension, identifiers, apiVersion, symbolicName) and their corresponding getters, setters, and JSON serialization logic across multiple models.
  • Incorporating additional null checks in JSON writers to ensure only non-null fields are serialized.

Reviewed Changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

Show a summary per file
File Description
WhatIfPropertyChange.java Adds null checks for serializing the before and after values.
WhatIfChange.java Introduces null checks for identifiers, before, and after fields.
TargetResource.java Adds new properties (extension, identifiers, apiVersion, symbolicName) with corresponding accessors and JSON output.
ResourceReference.java Adds new fields (extension, resourceType, identifiers, apiVersion) as part of the resource reference model.
HttpMessage.java Adds a null check for the content field before serialization.
ExtensionConfigPropertyType.java Introduces a new enum for extension configuration property types.
DeploymentWhatIfProperties.java Adds and serializes extensionConfigs with a corresponding null check.
DeploymentPropertiesExtended.java Adds extensions and new JSON serialization logic for deployment extensions.
DeploymentProperties.java Adds extensionConfigs field with serialization and validation logic.
DeploymentParameter.java Adds a null check for the parameter value during JSON serialization.
DeploymentExtensionDefinition.java Introduces the definition and JSON handling for deployment extension definitions.
DeploymentExtensionConfigItem.java Introduces the definition and JSON handling for deployment extension config items.
ResourceManagementClientImpl.java Updates the API version constant to "2025-03-01".
ResourceGroupExportResultInner.java Adds a null check for the template field during JSON serialization.
GenericResourceExpandedInner.java Adds a null check for the properties field during JSON serialization.
DeploymentExportResultInner.java Adds a null check for the template during JSON serialization.
assets.json Updates the asset tag to reflect the new version.
CHANGELOG.md Documents the API version upgrade in the changelog.
api-specs.json Updates the swagger generation argument with the new API version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants