Default enablement of Threshold-Based Availability Strategy with Per-Partition Automatic Failover. #45267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeet1995
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request enables a threshold‐based availability strategy for reads when Per-Partition Automatic Failover (PPAF) is enabled. Key changes include adding new duration constants and a helper method in Utils, updating RxDocumentClientImpl to propagate the end-to-end policy configuration, and introducing new configuration properties and test validations for the strategy.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Utils.java | Added duration constants and a min utility function to support latency configuration. |
| sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java | Updated multiple methods to pass an end-to-end policy configuration and added a new helper to apply the latency policy. |
| sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java | Introduced new config properties and a method to check if the read availability strategy is enabled with PPAF. |
| sdk/cosmos/azure-cosmos/docs/TimeoutAndRetriesConfig.md | Documented the new threshold strategy defaults for PPAF. |
| sdk/cosmos/azure-cosmos/CHANGELOG.md | Updated the changelog to include the new availability strategy feature. |
| sdk/cosmos/azure-cosmos-tests/ | Updated tests to validate the new strategy behavior under fault injection scenarios. |
Comments suppressed due to low confidence (1)
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java:227
- The delay has been increased from 10,000 milliseconds to 10,000 seconds and the repetition count changed from 1 to 10,000, which may lead to unintended long delays. Please verify that these values are intended.
.delay(Duration.ofSeconds(10000))
...cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/EndToEndTimeOutValidationTests.java
Outdated
Show resolved
Hide resolved
…ableAvailabilityStrategyWithPPAF
|
API change check API changes are not detected in this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title.
With default enablement of Threshold-Based Availability Strategy with Per-Partition Automatic Failover enablement, reads and queries will be hedged to second preferred region onwards.
The defaults to hedging are
1sto the second preferred region and then500msto reach out to the third preferred region and so on.A customer can choose to opt out of this through the following system property
[or] set
COSMOS_IS_READ_AVAILABILITY_STRATEGY_ENABLED_WITH_PPAFenvironment variable tofalse.A customer can choose to override above defaults by configuring
CosmosEndToEndLatencyPolicyConfigat request options level orCosmosClientBuilder. See below:All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines