Skip to content

Spring cloud azure 6.0 preview #45222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Spring cloud azure 6.0 preview #45222

wants to merge 15 commits into from

Conversation

mrm9084
Copy link
Member

@mrm9084 mrm9084 commented May 6, 2025

Description

Draft of new major release of the Azure App Configuration Libraries.

  • Many breaking Changes
  • Switches to the new Spring config system
  • Feature Flag Variants
  • Feature Flag Telemetry
  • Feature Flag Context
  • Feature Flags now created by default
  • Targeting Filter will now point at different users for Percentage. This will make it match the other libraries.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

mrm9084 and others added 14 commits December 16, 2024 11:20
@mrm9084
Spring Feature Management - RemoveV1Schema (#43405)
8dd4aae 
* RemoveV1Schema

* Removed targeting change

* extra java doc removed

* Review comments

* Update FeatureManagementException.java
@mrm9084
Merge branch 'main' into SpringCloudAzure6.0-Preview
48fdd28
@mrm9084
New Data loader (#43802)
c7a559a 
* UpdatedDataLoader

* Review Comments

* Web Updates

* Update ValidationsTest.java

* Removing Validation tests. They will be updated in there own PR.

* Review comments

* Fixing Refresh

* Update AzureAppConfigDataLocationResolver.java
@mrm9084
Fix Endian (#43932)
a6d8ed1 
* FixEndian

* rename method
@mrm9084 @rossgrambo
Feature context and Async Filters (#43435)
d3750bf 
* Object Context and AsyncFilters

* Apply suggestions from code review

Co-authored-by: Ross Grambo <[email protected]>

* Review comments

* Review comments

* Review Comments

---------

Co-authored-by: Ross Grambo <[email protected]>
@mrm9084
Push Refresh Telemetry (#44170)
a4de2bc 
* Updating to use Context to pass around telemetry + added pushRefreshEnabled

* Updated to PUSH_REFRESH + tests
@mrm9084
Update to use Evaluation Event (#44070)
cb2c369
@mrm9084
Adding Default Filters (#43935)
8ed4901 
* Adding Default Filters

* Fixing Feature flag loading after both redesigns

* Fixing issues after just 2.0 schema and properties

* Clearing up feature return

* fixing usage of default min backoff

* Removed dead code + tests

* Update TargetingContextAccessorTestConfiguration.java

* Update FeatureManagementConfiguration.java
@mrm9084 @Copilot
Variants (#42853)
736d9f5 
* variants

* Fixing Targeting Filter

* off by one

* Fixing Variant assignment

* review comments

* Default Timeout

* Update sdk/spring/spring-cloud-azure-feature-management/src/main/java/com/azure/spring/cloud/feature/management/filters/ContextualFeatureFilterAsync.java

Co-authored-by: Copilot <[email protected]>

* Review comments

* Fixing Merge Issues

* Update TargetingFilterTest.java

* Fixing doc comments and  removed ContextualAccessor

* fixed missing headers

* Removed dead code

* Update FeatureManager.java

* Update FeatureManager.java

* Update FeatureManager.java

---------

Co-authored-by: Copilot <[email protected]>
@mrm9084
Removed feature flags from configuration (#44558)
c394d7f
@mrm9084
Feature management Snapshot (#44621)
6ac0c5e 
* Feature Snapshot support

* Removing dead code

* Missing copyright

* Adding back Feature Filter telemetry

* Adding tests and simplifying code

* Update URI usage

* Update AzureAppConfigDataLoader.java
@mrm9084
Merge branch 'main' into SpringCloudAzure6.0-Preview
383d84d
@mrm9084
Adding missing java docs (#45169)
d59dafa
@mrm9084 @Copilot
Feature Management Telemetry (#45073)
57e5cc5 
* Feature Snapshot support

* Removing dead code

* Missing copyright

* Adding back Feature Filter telemetry

* Adding tests and simplifying code

* TelemetryPublisher

* Updating tests

* Added telemetry object

* Fixing tests

* Added more tests plus fixes

* Added publish telemetry tests

* Update sdk/spring/spring-cloud-azure-feature-management/src/main/java/com/azure/spring/cloud/feature/management/FeatureManager.java

Co-authored-by: Copilot <[email protected]>

* Adding Constants + Telemetry Package

* Fixing endpoint usage + isEnabled

* Remove Feature Id

* Update FeatureFlagClientTest.java

* FeatureId

* Removing featureflagid

* Adding allocation id

* fixed tests

* Updating Telemetry usage

* Fixing tests

* fixing build issues

* Update LoggerTelemetryPublisherTest.java

* Fix loading

---------

Co-authored-by: Copilot <[email protected]>
@github-actions github-actions bot added the azure-spring All azure-spring related issues label May 6, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 6, 2025 •
edited by github-actions bot
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.spring:spring-cloud-azure-appconfiguration-config
com.azure.spring:spring-cloud-azure-feature-management-web
com.azure.spring:spring-cloud-azure-feature-management

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 7, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.spring:spring-cloud-azure-appconfiguration-config
com.azure.spring:spring-cloud-azure-feature-management-web
com.azure.spring:spring-cloud-azure-feature-management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft will be requested when the pull request is marked ready for review alzimmermsft is a code owner

@samvaity samvaity Awaiting requested review from samvaity samvaity will be requested when the pull request is marked ready for review samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay will be requested when the pull request is marked ready for review g2vinay is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

@rujche rujche Awaiting requested review from rujche rujche will be requested when the pull request is marked ready for review rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy will be requested when the pull request is marked ready for review Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna will be requested when the pull request is marked ready for review saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan will be requested when the pull request is marked ready for review moarychan is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrm9084 @azure-sdk