Sync eng/common directory with azure-sdk-tools for PR 13561 #6910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the eng/common directory with changes from azure-sdk-tools PR #13561. The changes improve the robustness of the MCP tool installation script by adding error handling for file copy operations and proper cleanup of temporary directories.
Changes:
- Added error handling with graceful fallback when updating the executable fails in MCP mode
- Implemented cleanup of temporary installation directory after copy operation
- Modified success logging to only occur when the update actually succeeds
Comments suppressed due to low confidence (1)
eng/common/mcp/azure-sdk-mcp.ps1:178
- When the executable update fails in MCP mode (line 149-152), the script falls back to the existing installed version but doesn't verify that
$exeDestinationactually exists before attempting to start it on line 178. If no previous version exists, this will cause an error. Consider adding a check likeif (Test-Path $exeDestination)before the Start-Process call, or ensure the fallback message indicates the executable must already exist.
Start-Process -WorkingDirectory $RunDirectory -FilePath $exeDestination -ArgumentList 'start' -NoNewWindow -Wait
| } | ||
|
|
||
| if ($updateSucceeded) { | ||
| log "Executable $package is installed at $exeDestination" |
There was a problem hiding this comment.
The variable reference $package uses lowercase, but the parameter is defined as $Package (uppercase P) on line 8. PowerShell is case-insensitive for variables, but for consistency and readability, the casing should match the parameter definition. Change $package to $Package.
Suggested change
| log "Executable $package is installed at $exeDestination" | |
| log "Executable $Package is installed at $exeDestination" |
Co-authored-by: Copilot <[email protected]>
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/fix-lock-issue-13561
branch
from
8af8d18 to
0c1bfb9
Compare
raych1
approved these changes
Jan 16, 2026
azure-sdk
deleted the
sync-eng/common-users/raych1/fix-lock-issue-13561
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13561 See eng/common workflow