Skip to content

Conversation

@DanielMicrosoft
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@DanielMicrosoft
Copy link
Contributor Author

This commit will cause desired behaviour (pipeline fail on help generation error): 7128c98

But will attempt with pipeline config level fix.

@DanielMicrosoft
Copy link
Contributor Author

DanielMicrosoft commented Oct 30, 2025

Have cherry-picked the fix from release branch, to verify it will run green once help files are rectified.

@DanielMicrosoft DanielMicrosoft marked this pull request as ready for review October 31, 2025 04:29
Copilot AI review requested due to automatic review settings October 31, 2025 04:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds exit code validation to the analyze-steps.ps1 pipeline script to ensure that help generation and static analysis commands fail the pipeline appropriately when they encounter errors.

Key changes:

  • Introduced a new Assert-ExitCodeSuccess helper function to validate exit codes
  • Added exit code checks after help generation and static analysis operations

@dolauli dolauli self-assigned this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants