Skip to content

Remove ShouldProcess Parameter from Azure Firewall related Resources #28766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove ShouldProcess Parameter from Azure Firewall related Resources #28766

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc43ec
Remove ShouldProcess Paramter from Azure Firewall related Resources
bewatersmsft Oct 28, 2025
dc60b0e
Update src/Network/Network/ChangeLog.md
bewatersmsft Oct 28, 2025
3be608c
ipGroups support ShouldProcess
bewatersmsft Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Network/Network/AzureFirewall/SetAzureFirewallCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@

namespace Microsoft.Azure.Commands.Network
{
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "Firewall", SupportsShouldProcess = true), OutputType(typeof(PSAzureFirewall))]
// TODO: Support WhatIf https://github.com/Azure/azure-powershell/issues/27667
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "Firewall", SupportsShouldProcess = false), OutputType(typeof(PSAzureFirewall))]
public class SetAzureFirewallCommand : AzureFirewallBaseCmdlet
{
[Parameter(
Expand Down
3 changes: 2 additions & 1 deletion .../Network/AzureFirewallPolicy/RuleGroup/SetAzureFirewallPolicyRuleCollectionGroupCmdlet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@

namespace Microsoft.Azure.Commands.Network
{
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "FirewallPolicyRuleCollectionGroup", SupportsShouldProcess = true, DefaultParameterSetName = SetByNameParameterSet), OutputType(typeof(PSAzureFirewallPolicyRuleCollectionGroup))]
// TODO: Support WhatIf https://github.com/Azure/azure-powershell/issues/27667
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "FirewallPolicyRuleCollectionGroup", SupportsShouldProcess = false, DefaultParameterSetName = SetByNameParameterSet), OutputType(typeof(PSAzureFirewallPolicyRuleCollectionGroup))]
public class SetAzureFirewallPolicyRuleGroupCommand : AzureFirewallPolicyRuleCollectionGroupBaseCmdlet
{

Expand Down
3 changes: 2 additions & 1 deletion src/Network/Network/AzureFirewallPolicy/SetAzureFirewallPolicyCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@

namespace Microsoft.Azure.Commands.Network
{
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "FirewallPolicy", SupportsShouldProcess = true, DefaultParameterSetName = SetByNameParameterSet), OutputType(typeof(PSAzureFirewallPolicy))]
// TODO: Support WhatIf https://github.com/Azure/azure-powershell/issues/27667
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "FirewallPolicy", SupportsShouldProcess = false, DefaultParameterSetName = SetByNameParameterSet), OutputType(typeof(PSAzureFirewallPolicy))]
public class SetAzureFirewallPolicyCommand : AzureFirewallPolicyBaseCmdlet
{

Expand Down
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
## Upcoming Release

* Bug fix for `AzureFirewallPolicy` to ensure `BasePolicy` is properly set via `Set-AzFirewallPolicy` cmdlet either via pipe or direct value.
* Removal of `ShouldProcess` from `Set-AzFirewallPolicyRuleCollectionGroup`, `Set-AzFirewallPolicy`, `Set-AzFirewall`, and `Set-AzIpGroup` parameter as it has not been implemented yet.

## Version 7.22.0
* Added new RouteTableUsageMode property for Network Manager Routing Configuration
Expand Down
3 changes: 2 additions & 1 deletion src/Network/Network/IpGroup/SetIpGroupCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@

namespace Microsoft.Azure.Commands.Network
{
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "IpGroup", SupportsShouldProcess = true), OutputType(typeof(PSIpGroup))]
// TODO: Support WhatIf https://github.com/Azure/azure-powershell/issues/27667
[Cmdlet(VerbsCommon.Set, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "IpGroup", SupportsShouldProcess = false), OutputType(typeof(PSIpGroup))]
public class SetIpGroupsCommand : IpGroupBaseCmdlet
{
[Parameter(
Expand Down
Loading