Skip to content

Conversation

lijinpei2008
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008
Copy link
Contributor Author

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@lijinpei2008 lijinpei2008 added the Breaking Change Release This PR contains breaking change label Aug 18, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@jnlycklama
Copy link
Member

I tried to import the updates for this module to test but wasn't able to.

Steps:

  1. Clone repo and checkout this branch
  2. Build project using "msbuild build.proj"
  3. Import-Module C:\projects\azure-powershell\artifacts\Debug\Az.HealthcareApis\HealthcareApis.Autorest\Az.HealthcareApis.psm1
  4. "New-AzHealthcareDicomService -Name julietestdsjs -ResourceGroupName julie-test-ps -WorkspaceName julietestwsjs -SubscriptionId c92938d4-52af-4699-9011-d8070f593db5 -EnableSystemAssignedIdentity" -> gets error "A parameter cannot be found that matches parameter name 'EnableSystemAssignedIdentity'."

Is there something I'm doing wrong, or are the changes for this PR not ready yet?

@lijinpei2008
Copy link
Contributor Author

I tried to import the updates for this module to test but wasn't able to.

Steps:

  1. Clone repo and checkout this branch
  2. Build project using "msbuild build.proj"
  3. Import-Module C:\projects\azure-powershell\artifacts\Debug\Az.HealthcareApis\HealthcareApis.Autorest\Az.HealthcareApis.psm1
  4. "New-AzHealthcareDicomService -Name julietestdsjs -ResourceGroupName julie-test-ps -WorkspaceName julietestwsjs -SubscriptionId c92938d4-52af-4699-9011-d8070f593db5 -EnableSystemAssignedIdentity" -> gets error "A parameter cannot be found that matches parameter name 'EnableSystemAssignedIdentity'."

Is there something I'm doing wrong, or are the changes for this PR not ready yet?

The Announcement PR merger has had an impact on this PR with some code conflicts. The conflicts have been resolved. Please update the code and try again.

@lijinpei2008
Copy link
Contributor Author

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@lijinpei2008 lijinpei2008 marked this pull request as ready for review August 22, 2025 10:34
@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 10:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the generation tool version for the Az.HealthcareApis module from autorest.powershell v3 to v4. The update brings significant changes to the generated PowerShell cmdlets and help documentation, modernizing the module structure and parameter handling.

Key Changes:

  • Updated PowerShell module structure from v3 to v4 generation patterns
  • Enhanced help documentation with new parameter sets and improved documentation
  • Expanded cmdlet functionality with additional parameter support

Reviewed Changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.HealthcareApis/BreakingChangeIssues.csv Added comprehensive breaking change exception list documenting property type changes and parameter modifications
src/HealthcareApis/HealthcareApis/help/*.md Updated help documentation files with new parameter sets, improved descriptions, and modernized syntax
src/HealthcareApis/HealthcareApis/Az.HealthcareApis.psd1 Updated module manifest with new cmdlet and generation date
src/HealthcareApis/HealthcareApis.sln Updated solution file with new project GUID
src/HealthcareApis/HealthcareApis.Autorest/test/*.ps1 Updated test files with new test structure and naming conventions

@@ -0,0 +1,173 @@
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
Copy link
Preview

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSV file lacks a header comment explaining its purpose and structure. Consider adding a comment block at the top explaining what this file contains and how it's used in the build process.

Copilot uses AI. Check for mistakes.

@@ -3,7 +3,7 @@
#
# Generated by: Microsoft Corporation
#
# Generated on: 2025-08-08
# Generated on: 2025-08-01
Copy link
Preview

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generation date appears to be inconsistent with the PR metadata which indicates this is from August 2025. This might indicate the file was generated at a different time or the date format needs verification.

Copilot uses AI. Check for mistakes.

@jnlycklama
Copy link
Member

Thanks, it is working after the latest changes.

Tested for dicom service

  • Create w/ -EnableSystemAssignedIdentity
  • Update w/ -EnableSystemAssignedIdentity, $False to disable
  • Update w/ -UserAssignedIdentity
  • (after enabling private endpoint on the portal) Get dicom, validated private endpoint connections are correct

@ukachiokoli
Copy link

verified new JsonFilePath option of New-AzHealthcareApisWorkspace with Julie's help.
The rest of the changes look fine for Workspace CRUD documentation as well

@PTaladay
Copy link

Verified Fhir service creation and updates are working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants