-
Notifications
You must be signed in to change notification settings - Fork 4k
[Az.HealthcareApis] Update generation tool version: autorest.powershell v3->v4 #28317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
… jinpei/main/HealthcareApis-v4
To the author of the pull request, |
I tried to import the updates for this module to test but wasn't able to. Steps:
Is there something I'm doing wrong, or are the changes for this PR not ready yet? |
The Announcement PR merger has had an impact on this PR with some code conflicts. The conflicts have been resolved. Please update the code and try again. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the generation tool version for the Az.HealthcareApis module from autorest.powershell v3 to v4. The update brings significant changes to the generated PowerShell cmdlets and help documentation, modernizing the module structure and parameter handling.
Key Changes:
- Updated PowerShell module structure from v3 to v4 generation patterns
- Enhanced help documentation with new parameter sets and improved documentation
- Expanded cmdlet functionality with additional parameter support
Reviewed Changes
Copilot reviewed 72 out of 72 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tools/StaticAnalysis/Exceptions/Az.HealthcareApis/BreakingChangeIssues.csv | Added comprehensive breaking change exception list documenting property type changes and parameter modifications |
src/HealthcareApis/HealthcareApis/help/*.md | Updated help documentation files with new parameter sets, improved descriptions, and modernized syntax |
src/HealthcareApis/HealthcareApis/Az.HealthcareApis.psd1 | Updated module manifest with new cmdlet and generation date |
src/HealthcareApis/HealthcareApis.sln | Updated solution file with new project GUID |
src/HealthcareApis/HealthcareApis.Autorest/test/*.ps1 | Updated test files with new test structure and naming conventions |
@@ -0,0 +1,173 @@ | |||
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSV file lacks a header comment explaining its purpose and structure. Consider adding a comment block at the top explaining what this file contains and how it's used in the build process.
Copilot uses AI. Check for mistakes.
@@ -3,7 +3,7 @@ | |||
# | |||
# Generated by: Microsoft Corporation | |||
# | |||
# Generated on: 2025-08-08 | |||
# Generated on: 2025-08-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generation date appears to be inconsistent with the PR metadata which indicates this is from August 2025. This might indicate the file was generated at a different time or the date format needs verification.
Copilot uses AI. Check for mistakes.
Thanks, it is working after the latest changes. Tested for dicom service
|
verified new JsonFilePath option of New-AzHealthcareApisWorkspace with Julie's help. |
Verified Fhir service creation and updates are working as expected. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.