Skip to content

Network OOB Release #27790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025
Merged

Network OOB Release #27790

merged 6 commits into from
May 22, 2025

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Network OOB Release

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@VeryEarly VeryEarly marked this pull request as ready for review May 22, 2025 02:31
@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 02:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Az.Network module and related tooling for the 7.17.0 release, adds new features to the changelog and release notes, and bumps pipeline NodeTool versions.

  • Bumped Az.Network version to 7.17.0 across manifests and assembly info
  • Added Version 7.17.0 entry in ChangeLog and expanded release notes in Az.Network.psd1
  • Updated Publish-RMModules parameter sets and AutoRest NodeTool versionSpec in pipelines

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/ModulePublisher.psm1 Added CmdletBinding, new ParameterSet for ApiKey logic
tools/Docs/az-ps-latest-2.csv Updated Az.Network docs package version to 7.17.0
tools/AzPreview/AzPreview.psd1 Bumped Az.Network RequiredVersion to 7.17.0
tools/Az/Az.psd1 Bumped Az.Network RequiredVersion to 7.17.0
src/Network/Network/Properties/AssemblyInfo.cs Upgraded AssemblyVersion and AssemblyFileVersion
src/Network/Network/ChangeLog.md Added “## Version 7.17.0” under Upcoming Release
src/Network/Network/Az.Network.psd1 Updated ModuleVersion, generated date, and release notes
NuGet.Config Unintended trailing blank lines
.azure-pipelines/windows-powershell.yml Upgraded NodeTool versionSpec
.azure-pipelines/powershell-core.yml Upgraded NodeTool versionSpec
.azure-pipelines/azure-powershell-ci.yml Upgraded NodeTool versionSpec
Comments suppressed due to low confidence (2)

src/Network/Network/Az.Network.psd1:64

  • Commenting out the default ScriptsToProcess and TypesToProcess arrays may disable module initialization steps unexpectedly. Revert these to empty arrays or remove the lines if intentional, and add a comment explaining why they are disabled.
# ScriptsToProcess = @()

NuGet.Config:32

  • Two trailing blank lines were added at the end of the file. These are unnecessary and can be removed to keep the file clean.
+

@@ -206,6 +210,7 @@ function Publish-RMModules
$RepoLocation,

[Parameter(ParameterSetName="ByLocation", Mandatory=$true)]
[Parameter(ParameterSetName="ByName", Mandatory=$false)]
Copy link
Preview

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ApiKey parameter is assigned a new ParameterSet 'ByName' without corresponding sets defined on RepoName or Path, which may lead to ambiguous binding. Consider adding ParameterSetName attributes to related parameters (e.g. RepoName, Path) to fully define both 'ByName' and 'ByLocation' sets.

Copilot uses AI. Check for mistakes.

@@ -43,7 +43,7 @@ jobs:
- task: NodeTool@0
displayName: Install Autorest
inputs:
versionSpec: '18.20.7'
versionSpec: '18.20.8'
Copy link
Preview

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The NodeTool versionSpec is duplicated across multiple pipeline files. Consider extracting it into a variable or template to simplify updates and ensure consistency.

Suggested change
versionSpec: '18.20.8'
versionSpec: ${{ variables.NodeToolVersion }}

Copilot uses AI. Check for mistakes.

@VeryEarly VeryEarly self-assigned this May 22, 2025
@VeryEarly VeryEarly enabled auto-merge (squash) May 22, 2025 03:55
@VeryEarly VeryEarly merged commit 399f8cb into main May 22, 2025
12 checks passed
@VeryEarly VeryEarly deleted the oob/Network branch May 22, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants