-
Notifications
You must be signed in to change notification settings - Fork 4k
Network OOB Release #27790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network OOB Release #27790
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
bb0e651
to
070be02
Compare
070be02
to
d005920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Az.Network module and related tooling for the 7.17.0 release, adds new features to the changelog and release notes, and bumps pipeline NodeTool versions.
- Bumped Az.Network version to 7.17.0 across manifests and assembly info
- Added Version 7.17.0 entry in ChangeLog and expanded release notes in Az.Network.psd1
- Updated Publish-RMModules parameter sets and AutoRest NodeTool versionSpec in pipelines
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tools/ModulePublisher.psm1 | Added CmdletBinding, new ParameterSet for ApiKey logic |
tools/Docs/az-ps-latest-2.csv | Updated Az.Network docs package version to 7.17.0 |
tools/AzPreview/AzPreview.psd1 | Bumped Az.Network RequiredVersion to 7.17.0 |
tools/Az/Az.psd1 | Bumped Az.Network RequiredVersion to 7.17.0 |
src/Network/Network/Properties/AssemblyInfo.cs | Upgraded AssemblyVersion and AssemblyFileVersion |
src/Network/Network/ChangeLog.md | Added “## Version 7.17.0” under Upcoming Release |
src/Network/Network/Az.Network.psd1 | Updated ModuleVersion, generated date, and release notes |
NuGet.Config | Unintended trailing blank lines |
.azure-pipelines/windows-powershell.yml | Upgraded NodeTool versionSpec |
.azure-pipelines/powershell-core.yml | Upgraded NodeTool versionSpec |
.azure-pipelines/azure-powershell-ci.yml | Upgraded NodeTool versionSpec |
Comments suppressed due to low confidence (2)
src/Network/Network/Az.Network.psd1:64
- Commenting out the default ScriptsToProcess and TypesToProcess arrays may disable module initialization steps unexpectedly. Revert these to empty arrays or remove the lines if intentional, and add a comment explaining why they are disabled.
# ScriptsToProcess = @()
NuGet.Config:32
- Two trailing blank lines were added at the end of the file. These are unnecessary and can be removed to keep the file clean.
+
@@ -206,6 +210,7 @@ function Publish-RMModules | |||
$RepoLocation, | |||
|
|||
[Parameter(ParameterSetName="ByLocation", Mandatory=$true)] | |||
[Parameter(ParameterSetName="ByName", Mandatory=$false)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ApiKey parameter is assigned a new ParameterSet 'ByName' without corresponding sets defined on RepoName or Path, which may lead to ambiguous binding. Consider adding ParameterSetName attributes to related parameters (e.g. RepoName, Path) to fully define both 'ByName' and 'ByLocation' sets.
Copilot uses AI. Check for mistakes.
@@ -43,7 +43,7 @@ jobs: | |||
- task: NodeTool@0 | |||
displayName: Install Autorest | |||
inputs: | |||
versionSpec: '18.20.7' | |||
versionSpec: '18.20.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The NodeTool versionSpec is duplicated across multiple pipeline files. Consider extracting it into a variable or template to simplify updates and ensure consistency.
versionSpec: '18.20.8' | |
versionSpec: ${{ variables.NodeToolVersion }} |
Copilot uses AI. Check for mistakes.
Description
Network OOB Release
Checklist