Skip to content

NetworkCloud 2025-02-01 Stable API : powershell updates #27724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mfoster58
Copy link

@mfoster58 mfoster58 commented May 9, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

General availability of Az.NetworkCloud module with 2025-02-01 API version
Deploy-AzNetworkCloudCluster
Disable-AzNetworkCloudStorageApplianceRemoteVendo…
Enable-AzNetworkCloudStorageApplianceRemoteVendor…
Get-AzNetworkCloudAgentPool
Get-AzNetworkCloudBareMetalMachine
Get-AzNetworkCloudBareMetalMachineKeySet
Get-AzNetworkCloudBmcKeySet
Get-AzNetworkCloudCluster
Get-AzNetworkCloudClusterManager
Get-AzNetworkCloudConsole
Get-AzNetworkCloudKubernetesCluster
Get-AzNetworkCloudKubernetesClusterFeature
Get-AzNetworkCloudL2Network
Get-AzNetworkCloudL3Network
Get-AzNetworkCloudMetricsConfiguration
Get-AzNetworkCloudRack
Get-AzNetworkCloudRackSku
Get-AzNetworkCloudServicesNetwork
Get-AzNetworkCloudStorageAppliance
Get-AzNetworkCloudTrunkedNetwork
Get-AzNetworkCloudVirtualMachine
Get-AzNetworkCloudVolume
Invoke-AzNetworkCloudBareMetalMachineCordon
Invoke-AzNetworkCloudBareMetalMachineDataExtract
Invoke-AzNetworkCloudBareMetalMachineReimage
Invoke-AzNetworkCloudBareMetalMachineReplace
Invoke-AzNetworkCloudBareMetalMachineRunCommand
Invoke-AzNetworkCloudBareMetalMachineRunReadComma…
Invoke-AzNetworkCloudBareMetalMachineUncordon
Invoke-AzNetworkCloudClusterContinueVersionUpdate
Invoke-AzNetworkCloudClusterVersionUpdate
Invoke-AzNetworkCloudScanClusterRuntime
Invoke-AzNetworkCloudVirtualMachineReimage
New-AzNetworkCloudAgentPool
New-AzNetworkCloudBareMetalMachineConfigurationDa…
New-AzNetworkCloudBareMetalMachineKeySet
New-AzNetworkCloudBgpAdvertisementObject
New-AzNetworkCloudBgpServiceLoadBalancerConfigura…
New-AzNetworkCloudBmcKeySet
New-AzNetworkCloudCluster
New-AzNetworkCloudClusterManager
New-AzNetworkCloudConsole
New-AzNetworkCloudControlPlaneNodeConfigurationOb…
New-AzNetworkCloudEgressEndpointObject
New-AzNetworkCloudEndpointDependencyObject
New-AzNetworkCloudInitialAgentPoolConfigurationOb…
New-AzNetworkCloudIpAddressPoolObject
New-AzNetworkCloudKeySetUserObject
New-AzNetworkCloudKubernetesCluster
New-AzNetworkCloudKubernetesClusterFeature
New-AzNetworkCloudL2Network
New-AzNetworkCloudL3Network
New-AzNetworkCloudL3NetworkAttachmentConfiguratio…
New-AzNetworkCloudMetricsConfiguration
New-AzNetworkCloudNetworkAttachmentObject
New-AzNetworkCloudRackDefinitionObject
New-AzNetworkCloudServiceLoadBalancerBgpPeerObject
New-AzNetworkCloudServicesNetwork
New-AzNetworkCloudStorageApplianceConfigurationDa…
New-AzNetworkCloudTrunkedNetwork
New-AzNetworkCloudVirtualMachine
New-AzNetworkCloudVirtualMachinePlacementHintObje…
New-AzNetworkCloudVolume
Remove-AzNetworkCloudAgentPool
Remove-AzNetworkCloudBareMetalMachineKeySet
Remove-AzNetworkCloudBmcKeySet
Remove-AzNetworkCloudCluster
Remove-AzNetworkCloudClusterManager
Remove-AzNetworkCloudConsole
Remove-AzNetworkCloudKubernetesCluster
Remove-AzNetworkCloudKubernetesClusterFeature
Remove-AzNetworkCloudL2Network
Remove-AzNetworkCloudL3Network
Remove-AzNetworkCloudMetricsConfiguration
Remove-AzNetworkCloudServicesNetwork
Remove-AzNetworkCloudTrunkedNetwork
Remove-AzNetworkCloudVirtualMachine
Remove-AzNetworkCloudVolume
Restart-AzNetworkCloudBareMetalMachine
Restart-AzNetworkCloudKubernetesClusterNode
Restart-AzNetworkCloudVirtualMachine
Start-AzNetworkCloudBareMetalMachine
Start-AzNetworkCloudVirtualMachine
Stop-AzNetworkCloudBareMetalMachine
Stop-AzNetworkCloudVirtualMachine
Update-AzNetworkCloudAgentPool
Update-AzNetworkCloudBareMetalMachine
Update-AzNetworkCloudBareMetalMachineKeySet
Update-AzNetworkCloudBmcKeySet
Update-AzNetworkCloudCluster
Update-AzNetworkCloudClusterManager
Update-AzNetworkCloudConsole
Update-AzNetworkCloudKubernetesCluster
Update-AzNetworkCloudKubernetesClusterFeature
Update-AzNetworkCloudL2Network
Update-AzNetworkCloudL3Network
Update-AzNetworkCloudMetricsConfiguration
Update-AzNetworkCloudRack
Update-AzNetworkCloudServicesNetwork
Update-AzNetworkCloudStorageAppliance
Update-AzNetworkCloudTrunkedNetwork
Update-AzNetworkCloudVirtualMachine
Update-AzNetworkCloudVolume

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@@ -19,6 +19,9 @@
-->
## Upcoming Release

## Version 1.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version likely needs an update . e.g 1.2.0, will need to confirm on this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to 1.2.0

@mfoster58 mfoster58 marked this pull request as ready for review May 9, 2025 22:48
@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

Please fix the failed checks

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

Please fix the failed checks

@priyamshet
Copy link
Member

priyamshet commented May 15, 2025

Please fix the failed checks

Can we get some help/pointers on how to proceed with the failures we are seeing in the CI please?

@msJinLei
Copy link
Contributor

msJinLei commented May 20, 2025

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","MissingEndParenthesisInMethodCall","5200","1","Missing ')' in method call.","","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","UnexpectedToken","5200","1","Unexpected token 'userAssignedIdentityResourceId' in expression or statement.","userAssignedIdentityResourceId","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","MissingArgument","5200","1","Missing argument in parameter list.",",","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","0","MissingEndCurlyBrace","5200","1","Missing closing '}' in statement block or type definition.","{","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","UnexpectedToken","5200","1","Unexpected token ')' in expression or statement.",")","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","12","UnexpectedToken","5200","1","Unexpected token '}' in expression or statement.","}","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","MissingEndParenthesisInMethodCall","5200","1","Missing ')' in method call.","","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","UnexpectedToken","5200","1","Unexpected token 'userAssignedIdentityResourceId' in expression or statement.","userAssignedIdentityResourceId","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","MissingArgument","5200","1","Missing argument in parameter list.",",","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","0","MissingEndCurlyBrace","5200","1","Missing closing '}' in statement block or type definition.","{","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","UnexpectedToken","5200","1","Unexpected token ')' in expression or statement.",")","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","13","UnexpectedToken","5200","1","Unexpected token '}' in expression or statement.","}","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -AnalyticOutputSettingAnalyticsWorkspaceId is not a valid parameter name.","-AnalyticOutputSettingAnalyticsWorkspaceId","Check validity of the parameter -AnalyticOutputSettingAnalyticsWorkspaceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -AnalyticsOutputSettingsAssociatedIdentityType is not a valid parameter name.","-AnalyticsOutputSettingsAssociatedIdentityType","Check validity of the parameter -AnalyticsOutputSettingsAssociatedIdentityType."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -AnalyticsOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId is not a valid parameter name.","-AnalyticsOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId","Check validity of the parameter -AnalyticsOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -CommandOutputSettingsAssociatedIdentityType is not a valid parameter name.","-CommandOutputSettingsAssociatedIdentityType","Check validity of the parameter -CommandOutputSettingsAssociatedIdentityType."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -CommandOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId is not a valid parameter name.","-CommandOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId","Check validity of the parameter -CommandOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -SecretArchiveSettingVaultUri is not a valid parameter name.","-SecretArchiveSettingVaultUri","Check validity of the parameter -SecretArchiveSettingVaultUri."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -SecretArchiveSettingsAssociatedIdentityType is not a valid parameter name.","-SecretArchiveSettingsAssociatedIdentityType","Check validity of the parameter -SecretArchiveSettingsAssociatedIdentityType."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -SecretArchiveSettingsAssociatedIdentityUserAssignedIdentityResourceId is not a valid parameter name.","-SecretArchiveSettingsAssociatedIdentityUserAssignedIdentityResourceId","Check validity of the parameter -SecretArchiveSettingsAssociatedIdentityUserAssignedIdentityResourceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -UpdateStrategyWaitTimeMinutes is not a valid parameter name.","-UpdateStrategyWaitTimeMinutes","Check validity of the parameter -UpdateStrategyWaitTimeMinutes."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -VulnerabilityScanningSettingContainerScan is not a valid parameter name.","-VulnerabilityScanningSettingContainerScan","Check validity of the parameter -VulnerabilityScanningSettingContainerScan."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","12","Invalid_Parameter_Name","5011","1","Update-AzNetworkCloudCluster -ClusterType is not a valid parameter name.","-ClusterType","Check validity of the parameter -ClusterType."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","12","Invalid_Parameter_Name","5011","1","Update-AzNetworkCloudCluster -ClusterVersion is not a valid parameter name.","-ClusterVersion","Check validity of the parameter -ClusterVersion."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","12","Invalid_Parameter_Name","5011","1","Update-AzNetworkCloudCluster -ExtendedLocationName is not a valid parameter name.","-ExtendedLocationName","Check validity of the parameter -ExtendedLocationName."

@priyamshet please refer to the error messages above to fix the examples in the help docs of the cmdlets above

[CmdletBinding(PositionalBinding=$false)]
Param(

[Parameter(HelpMessage="The association of IP address pools to the communities and peers, allowing for announcement of IPs.")]
[Microsoft.Azure.PowerShell.Cmdlets.NetworkCloud.Models.Api20240701.IBgpAdvertisement[]]
[Microsoft.Azure.PowerShell.Cmdlets.NetworkCloud.Models.Api20250201.IBgpAdvertisement[]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is reported that the type is unable to find. Could you check again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
$securePassword = ConvertTo-SecureString "password" -asplaintext -force
$identityUserAssignedIdentity = @{}
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{})

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change and also added dummy value for $identityUserAssignedIdentity

}
$securePassword = ConvertTo-SecureString "password" -asplaintext -force
$identityUserAssignedIdentity = @{}
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{})

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change and also added dummy value for $identityUserAssignedIdentity

@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants