-
Notifications
You must be signed in to change notification settings - Fork 4k
Neon GA PowerShell CLI Command lets #27669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
… neon-ga-ps-cli-generator
…2/azure-powershell into neon-ga-ps-cli-generator
… neon-ga-ps-cli-generator
… neon-ga-ps-cli-generator
… neon-ga-ps-cli-generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the Neon GA PowerShell CLI commands for general availability by adding example markdown files with placeholders, updating command documentation with new parameter details, and aligning API and module versions.
- Added new example and help documentation files (e.g. Get-AzNeonPostgresCompute.md, Get-AzNeonPostgresBranch.md) with placeholders for titles, code, and outputs.
- Updated command documentation for organization, project, branch, compute, endpoint, database, and role operations with new parameter additions and adjusted API versions in UX JSON and AssemblyInfo files.
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
examples/*.md | Added placeholder examples for various cmdlets. |
docs/*.md | Updated command syntax and parameter lists; added new parameters. |
UX/Neon.Postgres/*.json | Updated API version and refined command specifications. |
README.md | Updated commit id and module version information. |
Properties/AssemblyInfo.cs | Updated assembly version to align with GA release. |
### Example 1: {{ Add title here }} | ||
```powershell | ||
{{ Add code here }} | ||
``` | ||
|
||
```output | ||
{{ Add output here (remove the output block if the example doesn't have an output) }} | ||
``` | ||
|
||
{{ Add description here }} | ||
|
||
### Example 2: {{ Add title here }} | ||
```powershell | ||
{{ Add code here }} | ||
``` | ||
|
||
```output | ||
{{ Add output here (remove the output block if the example doesn't have an output) }} | ||
``` | ||
|
||
{{ Add description here }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Replace placeholder text (e.g. '{{ Add title here }}', '{{ Add code here }}') with actual sample titles and code once available to ensure the examples are meaningful to end users.
### Example 1: {{ Add title here }} | |
```powershell | |
{{ Add code here }} | |
``` | |
```output | |
{{ Add output here (remove the output block if the example doesn't have an output) }} | |
``` | |
{{ Add description here }} | |
### Example 2: {{ Add title here }} | |
```powershell | |
{{ Add code here }} | |
``` | |
```output | |
{{ Add output here (remove the output block if the example doesn't have an output) }} | |
``` | |
{{ Add description here }} | |
### Example 1: Retrieve Compute Details for a Specific Neon Postgres Instance | |
```powershell | |
Get-AzNeonPostgresCompute -ResourceGroupName "MyResourceGroup" -ServerName "MyPostgresServer" |
{
"name": "MyPostgresServer",
"status": "Running",
"location": "East US",
"sku": {
"name": "GP_Gen5_4",
"tier": "GeneralPurpose",
"capacity": 4
}
}
This example retrieves the compute details of a specific Neon Postgres server, including its name, status, location, and SKU information.
Example 2: List All Neon Postgres Compute Resources in a Resource Group
Get-AzNeonPostgresCompute -ResourceGroupName "MyResourceGroup"
[
{
"name": "PostgresServer1",
"status": "Running",
"location": "East US",
"sku": {
"name": "GP_Gen5_2",
"tier": "GeneralPurpose",
"capacity": 2
}
},
{
"name": "PostgresServer2",
"status": "Stopped",
"location": "West US",
"sku": {
"name": "GP_Gen5_4",
"tier": "GeneralPurpose",
"capacity": 4
}
}
]
This example lists all Neon Postgres compute resources in the specified resource group, displaying details such as name, status, location, and SKU for each server.
Copilot uses AI. Check for mistakes.
[-MarketplaceDetailSubscriptionStatus <String>] [-OfferDetailOfferId <String>] [-OfferDetailPlanId <String>] | ||
[-OfferDetailPlanName <String>] [-OfferDetailPublisherId <String>] [-OfferDetailTermId <String>] | ||
[-OfferDetailTermUnit <String>] [-PartnerOrganizationPropertyOrganizationId <String>] | ||
[-PartnerOrganizationPropertyOrganizationName <String>] [-ProjectProperty <IProjectPropertiesUpdate>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Verify consistency of the 'ProjectProperty' type between Update and New command documentation (IProjectPropertiesUpdate vs IProjectProperties) to avoid confusion.
[-PartnerOrganizationPropertyOrganizationName <String>] [-ProjectProperty <IProjectPropertiesUpdate>] | |
[-PartnerOrganizationPropertyOrganizationName <String>] [-ProjectProperty <IProjectProperties>] |
Copilot uses AI. Check for mistakes.
@@ -40,7 +40,7 @@ try-require: | |||
- $(repo)/specification/liftrneon/resource-manager/readme.powershell.md | |||
|
|||
# For new RP, the version is 0.1.0 | |||
module-version: 0.1.0 | |||
module-version: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Ensure that the module version in the README aligns with the assembly version and overall release plan for consistency.
module-version: 1.0.0 | |
module-version: 2.3.4 |
Copilot uses AI. Check for mistakes.
### [Get-AzNeonPostgresBranch](Get-AzNeonPostgresBranch.md) | ||
Get a Branch | ||
|
||
### [Get-AzNeonPostgresCompute](Get-AzNeonPostgresCompute.md) | ||
List Compute resources by Branch | ||
|
||
### [Get-AzNeonPostgresEndpoint](Get-AzNeonPostgresEndpoint.md) | ||
List Endpoint resources by Branch | ||
|
||
### [Get-AzNeonPostgresNeonDatabase](Get-AzNeonPostgresNeonDatabase.md) | ||
List NeonDatabase resources by Branch | ||
|
||
### [Get-AzNeonPostgresNeonRole](Get-AzNeonPostgresNeonRole.md) | ||
List NeonRole resources by Branch | ||
|
||
### [Get-AzNeonPostgresOrganization](Get-AzNeonPostgresOrganization.md) | ||
Get a OrganizationResource | ||
|
||
### [Get-AzNeonPostgresProject](Get-AzNeonPostgresProject.md) | ||
Get a Project | ||
|
||
### [Get-AzNeonPostgresProjectConnectionUri](Get-AzNeonPostgresProjectConnectionUri.md) | ||
Action to retrieve the connection URI for the Neon Database. | ||
|
||
### [New-AzNeonPostgresBranch](New-AzNeonPostgresBranch.md) | ||
create a Branch | ||
|
||
### [New-AzNeonPostgresOrganization](New-AzNeonPostgresOrganization.md) | ||
create a OrganizationResource | ||
|
||
### [New-AzNeonPostgresProject](New-AzNeonPostgresProject.md) | ||
create a Project | ||
|
||
### [Remove-AzNeonPostgresBranch](Remove-AzNeonPostgresBranch.md) | ||
Delete a Branch | ||
|
||
### [Remove-AzNeonPostgresOrganization](Remove-AzNeonPostgresOrganization.md) | ||
Delete a OrganizationResource | ||
|
||
### [Remove-AzNeonPostgresProject](Remove-AzNeonPostgresProject.md) | ||
Delete a Project | ||
|
||
### [Update-AzNeonPostgresBranch](Update-AzNeonPostgresBranch.md) | ||
update a Branch | ||
|
||
### [Update-AzNeonPostgresOrganization](Update-AzNeonPostgresOrganization.md) | ||
update a OrganizationResource | ||
|
||
### [Update-AzNeonPostgresProject](Update-AzNeonPostgresProject.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Confirm that the grouping and order of cmdlet listings follow the established naming and presentation standards for easier discoverability.
### [Get-AzNeonPostgresBranch](Get-AzNeonPostgresBranch.md) | |
Get a Branch | |
### [Get-AzNeonPostgresCompute](Get-AzNeonPostgresCompute.md) | |
List Compute resources by Branch | |
### [Get-AzNeonPostgresEndpoint](Get-AzNeonPostgresEndpoint.md) | |
List Endpoint resources by Branch | |
### [Get-AzNeonPostgresNeonDatabase](Get-AzNeonPostgresNeonDatabase.md) | |
List NeonDatabase resources by Branch | |
### [Get-AzNeonPostgresNeonRole](Get-AzNeonPostgresNeonRole.md) | |
List NeonRole resources by Branch | |
### [Get-AzNeonPostgresOrganization](Get-AzNeonPostgresOrganization.md) | |
Get a OrganizationResource | |
### [Get-AzNeonPostgresProject](Get-AzNeonPostgresProject.md) | |
Get a Project | |
### [Get-AzNeonPostgresProjectConnectionUri](Get-AzNeonPostgresProjectConnectionUri.md) | |
Action to retrieve the connection URI for the Neon Database. | |
### [New-AzNeonPostgresBranch](New-AzNeonPostgresBranch.md) | |
create a Branch | |
### [New-AzNeonPostgresOrganization](New-AzNeonPostgresOrganization.md) | |
create a OrganizationResource | |
### [New-AzNeonPostgresProject](New-AzNeonPostgresProject.md) | |
create a Project | |
### [Remove-AzNeonPostgresBranch](Remove-AzNeonPostgresBranch.md) | |
Delete a Branch | |
### [Remove-AzNeonPostgresOrganization](Remove-AzNeonPostgresOrganization.md) | |
Delete a OrganizationResource | |
### [Remove-AzNeonPostgresProject](Remove-AzNeonPostgresProject.md) | |
Delete a Project | |
### [Update-AzNeonPostgresBranch](Update-AzNeonPostgresBranch.md) | |
update a Branch | |
### [Update-AzNeonPostgresOrganization](Update-AzNeonPostgresOrganization.md) | |
update a OrganizationResource | |
### [Update-AzNeonPostgresProject](Update-AzNeonPostgresProject.md) | |
### Get Cmdlets | |
#### [Get-AzNeonPostgresBranch](Get-AzNeonPostgresBranch.md) | |
Get a Branch | |
#### [Get-AzNeonPostgresCompute](Get-AzNeonPostgresCompute.md) | |
List Compute resources by Branch | |
#### [Get-AzNeonPostgresEndpoint](Get-AzNeonPostgresEndpoint.md) | |
List Endpoint resources by Branch | |
#### [Get-AzNeonPostgresNeonDatabase](Get-AzNeonPostgresNeonDatabase.md) | |
List NeonDatabase resources by Branch | |
#### [Get-AzNeonPostgresNeonRole](Get-AzNeonPostgresNeonRole.md) | |
List NeonRole resources by Branch | |
#### [Get-AzNeonPostgresOrganization](Get-AzNeonPostgresOrganization.md) | |
Get a OrganizationResource | |
#### [Get-AzNeonPostgresProject](Get-AzNeonPostgresProject.md) | |
Get a Project | |
#### [Get-AzNeonPostgresProjectConnectionUri](Get-AzNeonPostgresProjectConnectionUri.md) | |
Action to retrieve the connection URI for the Neon Database. | |
### New Cmdlets | |
#### [New-AzNeonPostgresBranch](New-AzNeonPostgresBranch.md) | |
create a Branch | |
#### [New-AzNeonPostgresOrganization](New-AzNeonPostgresOrganization.md) | |
create a OrganizationResource | |
#### [New-AzNeonPostgresProject](New-AzNeonPostgresProject.md) | |
create a Project | |
### Remove Cmdlets | |
#### [Remove-AzNeonPostgresBranch](Remove-AzNeonPostgresBranch.md) | |
Delete a Branch | |
#### [Remove-AzNeonPostgresOrganization](Remove-AzNeonPostgresOrganization.md) | |
Delete a OrganizationResource | |
#### [Remove-AzNeonPostgresProject](Remove-AzNeonPostgresProject.md) | |
Delete a Project | |
### Update Cmdlets | |
#### [Update-AzNeonPostgresBranch](Update-AzNeonPostgresBranch.md) | |
update a Branch | |
#### [Update-AzNeonPostgresOrganization](Update-AzNeonPostgresOrganization.md) | |
update a OrganizationResource | |
#### [Update-AzNeonPostgresProject](Update-AzNeonPostgresProject.md) |
Copilot uses AI. Check for mistakes.
{{ Add code here }} | ||
``` | ||
|
||
```output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill the examples
… neon-ga-ps-cli-generator
… neon-ga-ps-cli-generator
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
The reported issues for the md files
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.