Fix Instance Manager for Linux Consumption Running on Legion #11072
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tonewall - please add details on if this was recent regression in 4.1039.x also, check if 4.1038.x is OK |
The commit was introduced in 4.1039.x on march 21st. It's okay in 4.1038.x, but we don't have any 4.1038.x released to prod regions, we only released 4.1039.x |
jviau
approved these changes
May 22, 2025
pragnagopa
reviewed
May 22, 2025
yojagad
reviewed
May 22, 2025
src/WebJobs.Script.WebHost/WebHostServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
fabiocav
previously requested changes
May 22, 2025
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
yojagad
approved these changes
May 22, 2025
|
@Tonewall - please send a PR to inproc branch as well and update the PR description with the link |
kshyju
reviewed
May 23, 2025
pragnagopa
approved these changes
May 23, 2025
Tonewall
force-pushed
the
user/tonychoi/cv1-migration-instancemanager
branch
from
29eaa1d to
a95632a
Compare
pragnagopa
approved these changes
May 23, 2025
Tonewall
added a commit
that referenced
this pull request
May 23, 2025
* Fix Instance Manager for Linux Consumption Running on Legion * unit test * Release note --------- Co-authored-by: Tony Choi <[email protected]>
Tonewall
added a commit
that referenced
this pull request
May 23, 2025
* Fix Instance Manager for Linux Consumption Running on Legion * unit test * Release note --------- Co-authored-by: Tony Choi <[email protected]>
Tonewall
added a commit
that referenced
this pull request
May 23, 2025
* Fix Instance Manager for Linux Consumption Running on Legion * unit test * Release note --------- Co-authored-by: Tony Choi <[email protected]>
Tonewall
added a commit
that referenced
this pull request
May 23, 2025
* Fix Instance Manager for Linux Consumption Running on Legion * unit test * Release note --------- Co-authored-by: Tony Choi <[email protected]>
Tonewall
added a commit
that referenced
this pull request
May 24, 2025
* Fix Instance Manager for Linux Consumption Running on Legion * unit test * Release note --------- Co-authored-by: Tony Choi <[email protected]>
Tonewall
added a commit
that referenced
this pull request
May 24, 2025
* Fix Instance Manager for Linux Consumption Running on Legion * unit test * Release note --------- Co-authored-by: Tony Choi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
CV1 Migration pods are starting with the incorrect instance manager. Fixing the AddWebJobsScriptHost() to choose the correct instance manager based on the environment
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information