Skip to content

Conversation

@VineethReyya
Copy link
Contributor

@VineethReyya VineethReyya commented Apr 15, 2025

Issue describing the changes in this PR

Fix warnings in the project

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@VineethReyya VineethReyya requested a review from a team as a code owner April 15, 2025 12:07
@VineethReyya VineethReyya linked an issue Apr 15, 2025 that may be closed by this pull request
3 tasks
@VineethReyya
Copy link
Contributor Author

VineethReyya commented Apr 15, 2025

@aishwaryabh @liliankasem when you have a moment, please review the changes.
image
we are getting errors in build.csproj so commented the line <TreatWarningsAsErrors>true</TreatWarningsAsErrors>

@liliankasem
Copy link
Member

@VineethReyya just FYI that I fixed the build props and artifactassembler.cs files in my last 2 commits

@VineethReyya
Copy link
Contributor Author

@VineethReyya just FYI that I fixed the build props and artifactassembler.cs files in my last 2 commits

@liliankasem Thanks for the commits. I just commit few changes. could you please review.

Also tried to supress : NU5118 because in .csproj line no 298 we are trying to include the same file under two different PackagePaths. and also using both a wildcard include (***) and an explicit file include (main.py),
image

The issue can be resolved by removing the conflicting paths, but I’ve temporarily suppressed it until I receive your suggestion.

@liliankasem liliankasem changed the title 4320-enable warnings as errors and fix any issues Fix warnings in solution (excluding build csproj) Apr 16, 2025
@liliankasem
Copy link
Member

@VineethReyya just FYI that I fixed the build props and artifactassembler.cs files in my last 2 commits

@liliankasem Thanks for the commits. I just commit few changes. could you please review.

Also tried to supress : NU5118 because in .csproj line no 298 we are trying to include the same file under two different PackagePaths. and also using both a wildcard include (***) and an explicit file include (main.py), image

The issue can be resolved by removing the conflicting paths, but I’ve temporarily suppressed it until I receive your suggestion.

Lets keep supressed for now.

@liliankasem liliankasem merged commit acb4925 into main Apr 16, 2025
11 checks passed
@liliankasem liliankasem deleted the enable-warnings-as-errors-and-fix-any-issues-New branch April 16, 2025 21:59
@VineethReyya VineethReyya removed a link to an issue Apr 23, 2025
3 tasks
@VineethReyya VineethReyya linked an issue Apr 23, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix warnings in the repository

3 participants