Adding func start tests
#4364
Merged
Adding func start tests
#4364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishwaryabh
changed the title
func start testsfunc start tests
liliankasem
reviewed
Apr 14, 2025
liliankasem
reviewed
Apr 15, 2025
test/Cli/Func.E2ETests/Fixtures/PowershellFunctionAppFixture.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/VisualStudioTestProjects/TestNet6InProcProject/Function2.cs
Outdated
Show resolved
Hide resolved
|
Once the PR has been reviewed, I'll add a README.md on how to add E2E tests as well |
liliankasem
reviewed
Apr 17, 2025
aishwaryabh
force-pushed
the
aibhandari/func-start-tests
branch
2 times, most recently
from
167fb97 to
6342c08
Compare
liliankasem
reviewed
Apr 18, 2025
test/Cli/Func.E2ETests/VisualStudioTestProjects/TestNet6InProcProject/Dotnet6InProc.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/Runsettings/StartTests_dotnet_inproc_artifact_consolidation.runsettings
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/Commands/FuncStart/TestsWithFixtures/NodeV4Tests.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/Commands/FuncStart/TestsWithFixtures/NodeV4Tests.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/Commands/FuncStart/TestsWithFixtures/DotnetIsolatedTests.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/Commands/FuncStart/TestsWithFixtures/DotnetIsolatedTests.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2ETests/Commands/FuncStart/TestsWithFixtures/DotnetIsolatedTests.cs
Outdated
Show resolved
Hide resolved
aishwaryabh
force-pushed
the
aibhandari/func-start-tests
branch
from
4d5c70b to
1a00268
Compare
liliankasem
reviewed
Apr 22, 2025
test/Cli/Func.E2E.Tests/Fixtures/PowershellFunctionAppFixture.cs
Outdated
Show resolved
Hide resolved
test/Cli/Func.E2E.Tests/Commands/FuncStart/MissingConfigTests.cs
Outdated
Show resolved
Hide resolved
aishwaryabh
force-pushed
the
aibhandari/func-start-tests
branch
from
39bb66a to
b50fbae
Compare
… headers, and trying to get things to run
… uninstalling templates to see if it still works
aishwaryabh
force-pushed
the
aibhandari/func-start-tests
branch
from
b50fbae to
0024ac3
Compare
liliankasem
reviewed
Apr 23, 2025
test/Cli/Func.E2E.Tests/Commands/FuncStart/TestsWithFixtures/DotnetIsolatedTests.cs
Show resolved
Hide resolved
liliankasem
approved these changes
Apr 24, 2025
This was referenced Apr 24, 2025
satvu
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #4328
This PR is the last part of a series of PRs to set up a new testing framework for the Azure Functions CLI. This is the larger PR, which contains all the changes for the testing framework and the updated func start E2E test, if you would like to take a look at how it all fits in! I just decided to split it up since it would be easier to review and get feedback this way.
Func.E2ETests.csprojcontains the func start E2E tests that are refactored to use the new test framework. The tests utilize fixtures whenever possible, with the base class beingBaseFunctionAppFixture. The rest of the tests don't use a fixture and have to set up a function app with func init and func new for each test. Each test is also in its own unique working directory and using a unique port to avoid port conflicts.CI changes:
The yaml files have been updated to publish the TestLogs (the logs are dumped into a txt file and will show up even if the tests timeout). The Build.csproj has been updated to run the new Func.E2ETests.csproj as well.
Note the func start tests in the old framework have been removed in this PR as well. I've also added a timeout of 10min so that if a test is hanging, CI will timeout and publish the logs to the TestLogs folder.
Performance Impact
After running these tests on CI, the test time for func start E2E tests have reduced by more than 50%! With the testing method, the tests would take 19 min and the newer testing method takes 7-8 min!
Pull request checklist