allow user to disable provision preflight #4947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemarina
requested review from
wbreza,
vhvb1989,
weikanglim and
JeffreyCA
as code owners
|
There is something good about adding a grouping command like you did here with However, I don't think we need it. IMO, in this case we only need to support something like |
This is where my head is at, but I'm currently curious if we want to make this project-specific for now, something like:
My current observation is that this might be a very specific scenario based on this write-up here I'd still love for validate to be on by default, and basically make this a troubleshooting step until we hear more feedback otherwise. |
JeffreyCA
reviewed
Mar 17, 2025
JeffreyCA
reviewed
Mar 17, 2025
hemarina
changed the title
vhvb1989
reviewed
Mar 22, 2025
|
Chatted with @rajeshkamal5050. We will hold this PR in the backlog. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
vhvb1989
reviewed
Mar 28, 2025
| ) | ||
| if err != nil { | ||
| return nil, err | ||
| if strings.ToLower(p.env.Getenv(environment.DisablePreflightName)) != "true" { |
There was a problem hiding this comment.
.Getenv() falls back to check the system environment (not only the values from azd's .env file)
Do we want to make it only for azd's .env file?
In the warningMessage below we are telling folks they can run azd env set XXXXX false or remove the value from the .env; If the env var is set on system environment, should we re-word the error?
| @@ -46,6 +46,9 @@ const ResourceGroupEnvVarName = "AZURE_RESOURCE_GROUP" | |||
| // PlatformTypeEnvVarName is the name of the key used to store the current azd platform type | |||
| const PlatformTypeEnvVarName = "AZD_PLATFORM_TYPE" | |||
|
|
|||
| // DisablePreflightName is used to allow users to skip the preflight validation check | |||
| const DisablePreflightName = "AZURE_PROVISION_SKIP_VALIDATE" | |||
There was a problem hiding this comment.
Consider adding this env var to: https://github.com/Azure/azure-dev/blob/main/cli/azd/docs/environment-variables.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current method (set .env):
During the discussion on Monday, we went through three methods including set config, set .env, or add flag. It is clear to me that set config is not the way we want as this lets users to completely disable Preflight in all scenarios. We want the disabled functionality to be more project specific. I thought about the trades off between set .env vs add flag and discussed with @weikanglim. Considering our use case, we prefer to be environment/project-specific and speaks the same language that template authors want to speak to users. I believe set .env method is what we are looking for.
If disable:
allow user to disable it when an error is blocking:
Previous method (set config):
I used the similar logic of alpha feature and added option out feature so that we could use it to option out other features in future. If folks think it is duplication of alpha feature, happy to migrate it under alpha feature support or just directly support config.
After gathering folks feedback, update the method to directly support config:
Migrate to use
azd config set provision.disableValidation on. Usevalidationsince preflight is an internal word.If disable, run provision directly:
Allow user to disable it when an error is blocking:
