-
Notifications
You must be signed in to change notification settings - Fork 248
ci: mtu check for cilium e2e #3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an MTU check for Cilium e2e tests by deploying an nginx application and executing a validation script to compare pod and node MTU values.
- Adds a new nginx deployment manifest for Kubernetes
- Integrates MTU validation steps into multiple pipeline YAML templates
- Executes the cilium-mtu-validation.sh script via newly added CI steps
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
hack/manifests/nginx.yaml | New nginx deployment manifest for MTU testing deployed in kube-system |
.pipelines/templates/cilium-tests.yaml | Added CI step to deploy nginx and run MTU validation |
.pipelines/singletenancy/cilium/cilium-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-step-template.yaml | Added CI step for MTU validation |
.pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
.pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e-step-template.yaml | Added CI step for MTU validation |
.pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
.pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e-step-template.yaml | Added CI step for MTU validation |
.pipelines/cni/cilium/cilium-overlay-load-test-template.yaml | Extended load test with MTU validation steps |
Files not reviewed (1)
- hack/scripts/cilium-mtu-validation.sh: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to a template and also have the template call within cilium-tests.yaml
?
.pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e-step-template.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 last template call misses and 🚀
Reason for Change:
compare pod eth0 mtu with node eth0 mtu and verify same value
Issue Fixed:
Requirements:
Notes: