Skip to content

Conversation

@Tratcher
Copy link
Contributor

@Tratcher Tratcher commented Oct 28, 2025

The traffic section wasn't getting set because the container was crashing and never transitioning to a ready state. I replaced the container image and added a retry loop while waiting for the revision to come up.

"Container 'nginx' was terminated with exit code '1' and reason 'ContainerCreateFailure'. Status(StatusCode="Unknown", Detail="failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "npm": executable file not found in $PATH: unknown")"

Copilot AI review requested due to automatic review settings October 28, 2025 21:44
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 28, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Tratcher,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test_containerapp_create_with_yaml test to improve reliability and use Microsoft's official quickstart container image instead of nginx.

  • Replaces nginx container image with the official Microsoft quickstart image (mcr.microsoft.com/k8se/quickstart:latest)
  • Adds a wait loop to ensure the container app is fully provisioned before validation
  • Uncomments and enables previously disabled traffic configuration tests

@Greedygre
Copy link
Contributor

The Ci failed with 2 reason:
1.

- FAIL - HIGH severity: expired_parameter
    Parameter: containerapp env premium-ingress add, `max_replicas` - Deprecated parameter is expired and should be removed.
    Parameter: containerapp env premium-ingress add, `min_replicas` - Deprecated parameter is expired and should be removed.
    Parameter: containerapp env premium-ingress update, `max_replicas` - Deprecated parameter is expired and should be removed.
    Parameter: containerapp env premium-ingress update, `min_replicas` - Deprecated parameter is expired and should be removed.
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_azurefile.py::ContainerAppMountAzureFileTest::test_container_app_mount_azurefile_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_connected_env_scenario.py::ContainerappPreviewScenarioTest::test_containerapp_preview_connected_env_storage
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py::ContainerappEnvLocationNotInStageScenarioTest::test_containerapp_env_logs_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py::ContainerAppMountNfsAzureFileTest::test_container_app_mount_nfsazurefile_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_with_yaml.py::ContainerAppJobsExecutionsLocationNotInStageTest::test_containerappjob_create_with_yaml

@Tratcher
Copy link
Contributor Author

The deprecated values will be removed by #9265.

The e2e test failures are due to an update azure-cli version, not this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants