-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{containerapp} Fix test_containerapp_create_with_yaml test #9345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the test_containerapp_create_with_yaml test to improve reliability and use Microsoft's official quickstart container image instead of nginx.
- Replaces nginx container image with the official Microsoft quickstart image (
mcr.microsoft.com/k8se/quickstart:latest) - Adds a wait loop to ensure the container app is fully provisioned before validation
- Uncomments and enables previously disabled traffic configuration tests
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Outdated
Show resolved
Hide resolved
|
The Ci failed with 2 reason: |
|
The deprecated values will be removed by #9265. The e2e test failures are due to an update azure-cli version, not this PR. |
The traffic section wasn't getting set because the container was crashing and never transitioning to a ready state. I replaced the container image and added a retry loop while waiting for the revision to come up.
"Container 'nginx' was terminated with exit code '1' and reason 'ContainerCreateFailure'. Status(StatusCode="Unknown", Detail="failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "npm": executable file not found in $PATH: unknown")"