Skip to content

Conversation

@sdeguchi
Copy link
Contributor

@sdeguchi sdeguchi commented Feb 25, 2025

Overview/Summary

Update starter module default_postfix to optional_postfix as there is confusion between the default_postfix and postfix_number. Want to update to remove the confusion between the two.

This PR fixes/adds/changes/removes

  1. Update default_postfix to optional_postfix

Breaking Changes

  1. Breaks previous versions of FSI/SLZ starter module using default_postfix

Testing Evidence

In progress...

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@sdeguchi sdeguchi requested a review from a team February 25, 2025 21:57
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit deb68b3 into main Feb 26, 2025
7 checks passed
@jaredfholgate jaredfholgate deleted the feature-update-default-postfix branch February 26, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants