Skip to content

feat: Adding precondition checks for management groups #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaredfholgate merged 8 commits into from
Feb 18, 2025
Merged

feat: Adding precondition checks for management groups #69

jaredfholgate merged 8 commits into from
Feb 18, 2025

Conversation

@sdeguchi
Copy link
Contributor

@sdeguchi sdeguchi commented Feb 4, 2025 •
edited
Loading

Overview/Summary

Add custom error messages for management group configuration with missing required fields

This PR fixes/adds/changes/removes

  1. Feature Request: Add meaningful error messages for management group configuration Azure-Landing-Zones#2436

Breaking Changes

  1. None

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@sdeguchi sdeguchi requested a review from a team February 4, 2025 01:40
jaredfholgate
jaredfholgate requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few items

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Needs the author to provide feedback label Feb 4, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Needs the author to provide feedback label Feb 4, 2025
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Feb 18, 2025
jaredfholgate
jaredfholgate approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit 5d25396 into main Feb 18, 2025
31 checks passed
@jaredfholgate jaredfholgate deleted the feature-add-arch-def-preconditions branch February 18, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees

@sdeguchi sdeguchi

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdeguchi @jaredfholgate